Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Papua New Guinea holidays #1605

Merged
merged 6 commits into from
Dec 27, 2023

Conversation

PPsyrius
Copy link
Contributor

Proposed change

Add Papua New Guinea holidays.

Closes #1239 .

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@coveralls
Copy link

coveralls commented Dec 22, 2023

Pull Request Test Coverage Report for Build 7334395643

  • 45 of 45 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7305483925: 0.0%
Covered Lines: 10298
Relevant Lines: 10298

💛 - Coveralls

@PPsyrius PPsyrius marked this pull request as ready for review December 22, 2023 07:02
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New countries it's always great! 👍

holidays/countries/papua_new_guinea.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 🇵🇬 code looks good, just a few minor comments here:

holidays/countries/papua_new_guinea.py Outdated Show resolved Hide resolved
holidays/countries/papua_new_guinea.py Outdated Show resolved Hide resolved
holidays/countries/papua_new_guinea.py Outdated Show resolved Hide resolved
holidays/countries/papua_new_guinea.py Outdated Show resolved Hide resolved
PPsyrius and others added 2 commits December 27, 2023 09:15
Co-authored-by: Arkadii Yakovets <ark@cho.red>
Co-Authored-By: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>
Copy link

sonarcloud bot commented Dec 27, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

12 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r added this pull request to the merge queue Dec 27, 2023
Merged via the queue into vacanza:beta with commit ff75f24 Dec 27, 2023
26 checks passed
@PPsyrius PPsyrius deleted the papua_new_guinea_holidays branch December 28, 2023 03:29
@KJhellico KJhellico mentioned this pull request Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Papua New Guinea holidays
4 participants