Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Australia holidays #1736

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Update Australia holidays #1736

merged 2 commits into from
Mar 28, 2024

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Update Australia holidays (according to official sources).

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@coveralls
Copy link

coveralls commented Mar 19, 2024

Pull Request Test Coverage Report for Build 8470616463

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 333 of 333 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8348428447: 0.0%
Covered Lines: 10968
Relevant Lines: 10968

💛 - Coveralls

arkid15r
arkid15r previously approved these changes Mar 28, 2024
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work on 🇦🇺

Just a couple of suggestions:

holidays/countries/australia.py Outdated Show resolved Hide resolved
holidays/countries/australia.py Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Mar 28, 2024

Quality Gate Passed Quality Gate passed

Issues
15 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.9% Duplication on New Code

See analysis details on SonarCloud

@arkid15r arkid15r enabled auto-merge March 28, 2024 16:43
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this in, thanks @KJhellico

@arkid15r arkid15r added this pull request to the merge queue Mar 28, 2024
Merged via the queue into vacanza:dev with commit 455d1fd Mar 28, 2024
29 checks passed
@KJhellico KJhellico deleted the upd-australia branch March 28, 2024 17:10
@KJhellico KJhellico mentioned this pull request Apr 1, 2024
@engserv
Copy link

engserv commented Apr 8, 2024

Kings birthday is on September 23rd in Western Australia (WA) in 2024.
https://www.wa.gov.au/service/employment/workplace-agreements/public-holidays-western-australia

@arkid15r
Copy link
Collaborator

arkid15r commented Apr 8, 2024

Kings birthday is on September 23rd in Western Australia (WA) in 2024. https://www.wa.gov.au/service/employment/workplace-agreements/public-holidays-western-australia

Thanks for reporting this, I've created a new issue based on your comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Easter Sunday to AU-SA public holiday list Australia NSW - Bank Holiday only within Holiday data
4 participants