Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jordan holidays #1746

Merged
merged 21 commits into from
Apr 3, 2024
Merged

Add Jordan holidays #1746

merged 21 commits into from
Apr 3, 2024

Conversation

firaskafri
Copy link
Contributor

Proposed change

Added Jordan (Country) to supported countries.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@firaskafri firaskafri changed the title Tk add jordan country Add Jordan (Country) to supported countries Mar 31, 2024
@coveralls
Copy link

coveralls commented Apr 1, 2024

Pull Request Test Coverage Report for Build 8541663992

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 34 of 34 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8516352184: 0.0%
Covered Lines: 10997
Relevant Lines: 10997

💛 - Coveralls

@arkid15r arkid15r changed the title Add Jordan (Country) to supported countries Add Jordan holidays Apr 1, 2024
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @firaskafri,
thanks for adding another country support!

Please see some minor comments to address before merging this PR:

holidays/countries/jordan.py Outdated Show resolved Hide resolved
holidays/countries/jordan.py Outdated Show resolved Hide resolved
holidays/locale/ar/LC_MESSAGES/JO.po Outdated Show resolved Hide resolved
holidays/locale/en_US/LC_MESSAGES/JO.po Outdated Show resolved Hide resolved
holidays/registry.py Outdated Show resolved Hide resolved
holidays/countries/jordan.py Outdated Show resolved Hide resolved
@arkid15r arkid15r requested a review from abh31000 April 1, 2024 16:39
@arkid15r
Copy link
Collaborator

arkid15r commented Apr 1, 2024

@abh31000, could you review this when you get a chance?

Thank you!

Copy link
Contributor

@abh31000 abh31000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more correct. And it's unified across all the other AR locales

holidays/countries/jordan.py Outdated Show resolved Hide resolved
holidays/locale/ar/LC_MESSAGES/JO.po Outdated Show resolved Hide resolved
holidays/locale/en_US/LC_MESSAGES/JO.po Outdated Show resolved Hide resolved
tests/countries/test_jordan.py Outdated Show resolved Hide resolved
tests/countries/test_jordan.py Outdated Show resolved Hide resolved
firaskafri and others added 12 commits April 2, 2024 13:23
Co-authored-by: Arkadii Yakovets <ark@cho.red>
Co-authored-by: Arkadii Yakovets <ark@cho.red>
Co-authored-by: Arkadii Yakovets <ark@cho.red>
Co-authored-by: Arkadii Yakovets <ark@cho.red>
Co-authored-by: abh31000 <abdelkhalekbouklihacene67@gmail.com>
Co-authored-by: abh31000 <abdelkhalekbouklihacene67@gmail.com>
Co-authored-by: abh31000 <abdelkhalekbouklihacene67@gmail.com>
Co-authored-by: abh31000 <abdelkhalekbouklihacene67@gmail.com>
Co-authored-by: abh31000 <abdelkhalekbouklihacene67@gmail.com>
@firaskafri
Copy link
Contributor Author

Hey @arkid15r @abh31000 !

Thank you for the review, all addressed now.

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@firaskafri, thank you for your contribution! A couple of fixes:

holidays/countries/jordan.py Outdated Show resolved Hide resolved
holidays/countries/jordan.py Outdated Show resolved Hide resolved
holidays/countries/jordan.py Outdated Show resolved Hide resolved
holidays/locale/ar/LC_MESSAGES/JO.po Outdated Show resolved Hide resolved
holidays/locale/en_US/LC_MESSAGES/JO.po Outdated Show resolved Hide resolved
tests/countries/test_jordan.py Outdated Show resolved Hide resolved
@firaskafri
Copy link
Contributor Author

thank you @KJhellico , all fixed. Thanks!

firaskafri and others added 4 commits April 2, 2024 17:07
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
firaskafri and others added 2 commits April 2, 2024 17:08
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @firaskafri. Thanks for fixing all the comments! The PR looks very decent, I'm going to take another look today and merge it.

Here is an optional comment to address -- we've introduced AUTHORS file quite recently. Would you like to update it and add your name to the list?

@abh31000 thanks for reviewing the holiday names!

Copy link

sonarcloud bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@arkid15r arkid15r enabled auto-merge April 3, 2024 15:49
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @firaskafri, I've updated the AUTHORS file and merging this PR in.

Thanks a lot for adding another country holidays support!

@arkid15r arkid15r added this pull request to the merge queue Apr 3, 2024
Merged via the queue into vacanza:dev with commit b09e276 Apr 3, 2024
29 checks passed
This was referenced Apr 3, 2024
@arkid15r arkid15r mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants