Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Laos holidays #1797

Merged
merged 1 commit into from
May 20, 2024
Merged

Refactor Laos holidays #1797

merged 1 commit into from
May 20, 2024

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Refactor Laos holidays (Year-End Bank Holiday).

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@KJhellico KJhellico requested a review from arkid15r as a code owner May 19, 2024 13:56
Copy link

sonarcloud bot commented May 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@KJhellico
Copy link
Collaborator Author

We could optimize it more, but we'd end up with something more like some quiz:

        self._add_holiday(
            name,
            self._get_next_workday(
                self._add_holiday(
                    name,
                    self._get_next_workday(
                        self._add_holiday(
                            name, self._get_next_workday(self._next_year_new_years_day, -1)
                        ),
                        -1,
                    ),
                ),
                -1,
            ),
        )

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9148170463

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9133593995: 0.0%
Covered Lines: 11173
Relevant Lines: 11173

💛 - Coveralls

Copy link
Contributor

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇱🇦

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@arkid15r arkid15r added this pull request to the merge queue May 20, 2024
Merged via the queue into vacanza:dev with commit c94e6cc May 20, 2024
29 checks passed
@KJhellico KJhellico deleted the ref-laos branch May 20, 2024 16:05
@arkid15r arkid15r mentioned this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants