Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2024 Russian Substituted Holidays #1799

Merged
merged 3 commits into from
May 23, 2024

Conversation

PPsyrius
Copy link
Contributor

@PPsyrius PPsyrius commented May 21, 2024

Proposed change

Add 2024 Russian Substituted Holidays.

This PR supersedes and resolves #1760 (@summicron502 's) - with all issues resolved and all suggestions implemented.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

Co-Authored-By: summicron502 <152481672+summicron502@users.noreply.github.com>
@coveralls
Copy link

coveralls commented May 21, 2024

Pull Request Test Coverage Report for Build 9201614844

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9196919861: 0.0%
Covered Lines: 11276
Relevant Lines: 11276

💛 - Coveralls

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I have an ambivalent feeling about Russia and its holidays, I'm going to offer a correction.

holidays/countries/russia.py Outdated Show resolved Hide resolved
holidays/countries/russia.py Outdated Show resolved Hide resolved
Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com>
@PPsyrius PPsyrius requested a review from KJhellico May 23, 2024 02:58
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@arkid15r arkid15r enabled auto-merge May 23, 2024 04:03
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r added this pull request to the merge queue May 23, 2024
Merged via the queue into vacanza:dev with commit 50a5ffd May 23, 2024
29 checks passed
@PPsyrius PPsyrius deleted the rus-2024-substituted-holidays branch May 24, 2024 02:52
@KJhellico KJhellico mentioned this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants