Download pod logs #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbertoSoutullo
force-pushed
the
Alberto/download-pod-logs
branch
from
10b9282
to
83f9193
Compare
AlbertoSoutullo
force-pushed
the
Alberto/download-pod-logs
branch
from
83f9193
to
0f62d97
Compare
AlejandroCabeza
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubernetes.config.is something that is not pickable by python, but we need this configuration to access to the API.I could do several things here, but most of them were about taking out the configuration and hence the API access from the class.
This was a very specific case where it is one of the very few occasions we will want to do something asynchronously in the cluster. I decided to create a static method in the class, so we don't have to take out the client and its configuration outside the class. This allows us to do calls asynchronously, since each call will create a new client configuration instead of trying to pickle it.