Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump thanos metrics to csv #3

Merged
merged 20 commits into from
Mar 1, 2024
Merged

Dump thanos metrics to csv #3

merged 20 commits into from
Mar 1, 2024

Conversation

AlbertoSoutullo
Copy link
Collaborator

@AlbertoSoutullo AlbertoSoutullo commented Feb 14, 2024

Small PR to slowly give you a vision on how the repo is going.

I am starting with the metrics scrapping since the deployment is working, and the metrics are the only “problem” right now.
Each metric should have its own template, but I am still not sure if we will inject this in a Helm chart, or we add is as a some kind of YAML config.

What this does is query Thanos, prepare the data as a .csv, and dump it locally. I will add tests when we have a better direction of how to settle the configuration, since this can still vary a lot.

@AlejandroCabeza please, feel free to be as picky as you want.

src/metrics/scrapper.py Show resolved Hide resolved
src/metrics/scrapper.py Outdated Show resolved Hide resolved
src/metrics/scrapper.py Show resolved Hide resolved
src/metrics/scrapper.py Outdated Show resolved Hide resolved
src/metrics/scrapper.py Show resolved Hide resolved
@AlbertoSoutullo AlbertoSoutullo marked this pull request as ready for review February 23, 2024 10:36
@AlbertoSoutullo
Copy link
Collaborator Author

@AlejandroCabeza This is ready for review.

  • Scrapping configuration is now in a file scrape.yaml
  • Minor refactors
  • Added tests

Copy link
Contributor

@AlejandroCabeza AlejandroCabeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbertoSoutullo AlbertoSoutullo merged commit b79d4c8 into metrics_scrapper Mar 1, 2024
@AlbertoSoutullo AlbertoSoutullo added the 10k:main General work label Apr 15, 2024
@AlbertoSoutullo AlbertoSoutullo deleted the dump_data branch May 24, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10k:main General work
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants