Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gas-report tracking on repository #25

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Add gas-report tracking on repository #25

merged 3 commits into from
Sep 19, 2023

Conversation

3esmit
Copy link

@3esmit 3esmit commented Sep 18, 2023

Fixes #21

Description

  • Add npm run gas-report to save the reports of gas usage of each function in the smart contracts of interest.

  • sets foundry.toml to gas_reports = ["MiniMeToken", "MiniMeTokenFactory"]

  • add first .gas-report

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Added natspec comments?
  • Ran forge snapshot?
  • Ran pnpm lint?
  • Ran forge test?

Copy link
Collaborator

@0x-r4bbit 0x-r4bbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @3esmit !
I assume we want this to be added/executed whenever there's changes to the source.
Would you mind also updating the PULL_REQUEST.md so that we have a checkbox for pnpm gas-report ?

@3esmit 3esmit merged commit 85ca91c into master Sep 19, 2023
6 checks passed
@3esmit 3esmit deleted the gas-report branch September 26, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParentToken Mutability
2 participants