Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Ambiguous call - getCurrentProcessId #23

Closed
mratsim opened this issue Jun 25, 2019 · 0 comments
Closed

[Windows] Ambiguous call - getCurrentProcessId #23

mratsim opened this issue Jun 25, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@mratsim
Copy link
Contributor

mratsim commented Jun 25, 2019

The getCurrentProcessId defined here:

https://github.com/status-im/nim-libp2p/blob/3493b9ff7f02b34ea195893258a23c19e751c5f6/libp2p/daemon/daemonapi.nim#L530-L531

conflicts with std-shims:

https://github.com/status-im/nim-std-shims/blob/7fa381eb8d12a21bd1c7a1b99217b4cf8acacc46/std_shims/os_shims.nim#L10-L15

This triggers failures in nim-beacon-chain CI
https://ci.appveyor.com/project/nimbus/nim-beacon-chain/builds/25507340/job/u0nc6bt7kmq9glt4#L592

It should probably import and reexpert it from std-shims instead.
@mratsim mratsim added the bug Something isn't working label Jun 25, 2019
@mratsim mratsim changed the title [Windows] Ambiguous call - getCurrentProcessIds [Windows] Ambiguous call - getCurrentProcessId Jun 25, 2019
mratsim added a commit that referenced this issue Jun 25, 2019
@mratsim
Fix #23 - getCurrentProcessId conflict with std_shims/os_shims
cc2a525
@mratsim mratsim mentioned this issue Jun 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #23 - getCurrentProcessId conflict with std_shims/os_shims vacp2p/nim-libp2p
1 participant
@mratsim