Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test refc in CI in Nim 2.0 and later #1024

Closed
wants to merge 4 commits into from
Closed

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Feb 18, 2024

No description provided.

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fe4ff79) 83.28% compared to head (d71326d) 83.27%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           unstable    #1024      +/-   ##
============================================
- Coverage     83.28%   83.27%   -0.02%     
============================================
  Files            91       91              
  Lines         15442    15442              
============================================
- Hits          12861    12859       -2     
- Misses         2581     2583       +2     

see 4 files with indirect coverage changes

@tersec
Copy link
Contributor Author

tersec commented Feb 18, 2024

This should test ORC on 2.0+ too, to be consistent elsewhere, but refc is the priority, so it does that.

@tersec
Copy link
Contributor Author

tersec commented Feb 18, 2024

linux-i386 (Nim version-2-0) is failing because of nim-lang/Nim#23319 due to

  let dst: Rect = (x.int, y.int, src.w * scale, src.h * scale)

in https://github.com/ftsf/nico/blob/60dc2f34f6d57e1f4bc4a8565a43950dfdc1cfd5/nico.nim#L2220-L2227 which is used as one of the example tests.

@diegomrsantos
Copy link
Collaborator

diegomrsantos commented Feb 18, 2024

we are testing Nim 2.0 on the daily job. Same for i386.

@tersec
Copy link
Contributor Author

tersec commented Feb 18, 2024

ok

@tersec tersec closed this Feb 18, 2024
@tersec tersec deleted the test-refc-in-nim-20 branch February 18, 2024 22:01
@tersec
Copy link
Contributor Author

tersec commented Feb 19, 2024

Specifically Nim 2.0 with refc? The default is ORC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants