-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for setting protocol handlers with {.raises.}
annotation
#1064
Merged
Commits on Mar 11, 2024
-
add support for setting protocol handlers with
{.raises.}
annotationAll of the internal protocol handlers are restricted to `{.raises.}` of `[CancelledError]`. However, the `LPProtoHandler` type is part of the public interface, and example / test code raises more errors than just `[CancelledError]`. The caller is aware of that and `CatchableError` is caught. To allow annotating the internal handlers with the proper `{.raises`.} annotation, support for an extra `LPProtoHandler2` is added. This is backward compatible as the old `LPProtoHandler` is still allowed. Examples still compile fine. There is one test that needs a slight adjustment as it accesses the internal `handler` field directly. That field needs to be renamed so that the `template` is used instead. Eventually, `LPProtoHandler` may be phased out, with appropriate notices to users who define custom handlers and the migration requiring errors to be handled inside the handler instead of raising them. At this time, such a deprecation is not yet applied, especially while the internal logic is still relying on the previous handler flow.
Configuration menu - View commit details
-
Copy full SHA for 14fee3b - Browse repository at this point
Copy the full SHA 14fee3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 417922c - Browse repository at this point
Copy the full SHA 417922cView commit details
Commits on Mar 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 302359b - Browse repository at this point
Copy the full SHA 302359bView commit details
Commits on Mar 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 69f18ec - Browse repository at this point
Copy the full SHA 69f18ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 843fb45 - Browse repository at this point
Copy the full SHA 843fb45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 967c40c - Browse repository at this point
Copy the full SHA 967c40cView commit details
Commits on Mar 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 71dbcef - Browse repository at this point
Copy the full SHA 71dbcefView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3af3aa5 - Browse repository at this point
Copy the full SHA 3af3aa5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.