Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid cancelling send future #1075

Merged
merged 2 commits into from
Mar 20, 2024
Merged

avoid cancelling send future #1075

merged 2 commits into from
Mar 20, 2024

Conversation

arnetheduck
Copy link
Contributor

otherwise, the use of asyncSpawn results in breakage

otherwise, the use of `asyncSpawn` results in breakage
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.51%. Comparing base (49a92e5) to head (5ed400d).
Report is 2 commits behind head on unstable.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           unstable    #1075      +/-   ##
============================================
- Coverage     82.57%   82.51%   -0.07%     
============================================
  Files            91       91              
  Lines         15812    15848      +36     
============================================
+ Hits          13057    13077      +20     
- Misses         2755     2771      +16     
Files Coverage Δ
libp2p/protocols/pubsub/pubsubpeer.nim 88.23% <0.00%> (-0.35%) ⬇️

... and 9 files with indirect coverage changes

@diegomrsantos
Copy link
Collaborator

supersedes #1074

@arnetheduck arnetheduck enabled auto-merge (squash) March 20, 2024 10:43
@arnetheduck arnetheduck merged commit 467b5b4 into unstable Mar 20, 2024
9 checks passed
@arnetheduck arnetheduck deleted the cancel-fix branch March 20, 2024 10:54
@diegomrsantos
Copy link
Collaborator

@arnetheduck my local nimbus node crashed when running using unstable:

libbacktrace error: no debugging symbols available. Compile with '--debugger:native'.
Error: unhandled exception: Asynchronous task [sendMsgSlow() at pubsubpeer.nim:303] was cancelled! [FutureDefect]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants