fix: remove explicit param from GossipSubParams constructor #1080
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe
explicit
is used to check if theGossipSubParams
instance was created by the user either passing params toGossipSubParams(...)
orGossipSubParams.init(...)
. In the first caseexplicit
should be set totrue
when calling theNim
constructor, in the second case, the param isn't necessary and should be always be set to true byinit
. If none of those options were used, it means the instance was created by using Nim default values. In this case,GossipSubParams.init()
should be called to set the values to their default value defined by nim-libp2p.https://github.com/status-im/nim-libp2p/blob/5e55ca3b69e18a56a0a5a34941676f4df08523ae/libp2p/protocols/pubsub/gossipsub.nim#L774