Websocket Transport #593
Merged
Websocket Transport #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dryajov
reviewed
Jun 24, 2021
Menduist
force-pushed
the
wsv1
branch
2 times, most recently
from
472b352
to
6a71b20
Compare
Codecov Report
@@ Coverage Diff @@
## unstable #593 +/- ##
============================================
+ Coverage 81.96% 81.99% +0.02%
============================================
Files 59 60 +1
Lines 11579 11725 +146
============================================
+ Hits 9491 9614 +123
- Misses 2088 2111 +23
|
Menduist
force-pushed
the
transportsimprove
branch
from
a0c627a
to
1cf1372
Compare
dryajov
reviewed
Jul 1, 2021
dryajov
reviewed
Jul 1, 2021
dryajov
reviewed
Jul 1, 2021
dryajov
reviewed
Jul 1, 2021
libp2p/transports/wstransport.nim
Outdated
|
|
||
| try: | ||
| let | ||
| transp = await self.httpserver.accept() |
There was a problem hiding this comment.
Lots of potential to unify with tcp transport accept, specially after we've enabled multiple address listening.
There was a problem hiding this comment.
Yep, when #598 will be more stable I'll rebase this PR on it and add the required changes :)
Closed
|
Never mind, they are there 👍 |
dryajov
reviewed
Jul 18, 2021
|
LGTM, besides the missing |
dryajov
previously approved these changes
Jul 19, 2021
dryajov
approved these changes
Jul 22, 2021
dryajov
added a commit
that referenced
this pull request
Sep 8, 2021
* start of websocket transport * more ws tests * switch to common test * add close to wsstream * update ws & chronicles version * cleanup * removed multicodec * clean ws outgoing connections * renamed to websock * removed stream from logs * renamed ws to websock * add connection closing test to common transport * close incoming connection on ws stop * renamed testwebsocket.nim -> testwstransport.nim * removed raise todo * split out/in connections * add wss to tests * Fix tls (#608) * change log level * fixed issue related to stopping some cosmetic cleanup * use `allFutures` to stop/close things Prevent potential race conditions when stopping two or more transports * misc * point websock to server-case-object branch * interop test with go * removed websock version specification * add daemon -> native ws test * fix & test closed read/write * update readOnce, thanks jangko Co-authored-by: Dmitriy Ryajov <dryajov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #407
Full WIP
Edit: green ci!