Add Tor Transport support #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegomrsantos
force-pushed
the
add-socks5-support
branch
from
16391db
to
eeccc0e
Compare
Menduist
reviewed
Sep 15, 2022
Menduist
reviewed
Sep 15, 2022
Menduist
reviewed
Sep 15, 2022
Menduist
reviewed
Sep 15, 2022
4 tasks
Menduist
reviewed
Sep 19, 2022
Menduist
reviewed
Sep 19, 2022
lchenut
reviewed
Sep 22, 2022
diegomrsantos
force-pushed
the
add-socks5-support
branch
from
f50f58c
to
4b146ad
Compare
diegomrsantos
changed the base branch from
unstable
to
optional-observed-addr
diegomrsantos
force-pushed
the
add-socks5-support
branch
3 times, most recently
from
08bdb26
to
13e0508
Compare
diegomrsantos
force-pushed
the
add-socks5-support
branch
from
2e22e85
to
3132813
Compare
diegomrsantos
commented
Oct 26, 2022
lchenut
reviewed
Oct 26, 2022
lchenut
reviewed
Oct 26, 2022
lchenut
reviewed
Oct 26, 2022
libp2p/transports/tortransport.nim
Outdated
| transp: StreamTransport, address: MultiAddress) {.async, gcsafe.} = | ||
|
|
||
| let addressArray = ($address).split('/') | ||
| let addressStr = addressArray[2].split(':')[0] & ".onion" |
There was a problem hiding this comment.
Could this be an index error in certain weird case?
There was a problem hiding this comment.
Not sure. Is it possible to do it in a safer way?
There was a problem hiding this comment.
if addressArray.len < 2: raise whatever
diegomrsantos
force-pushed
the
add-socks5-support
branch
from
f36e2f9
to
f9db6c9
Compare
diegomrsantos
force-pushed
the
add-socks5-support
branch
from
83171a9
to
808f379
Compare
diegomrsantos
force-pushed
the
add-socks5-support
branch
from
33bb876
to
06c1f31
Compare
Menduist
reviewed
Nov 2, 2022
Menduist
reviewed
Nov 2, 2022
diegomrsantos
force-pushed
the
add-socks5-support
branch
from
0aa4d49
to
7618750
Compare
Menduist
approved these changes
Nov 4, 2022
This was referenced Nov 7, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a libp2p transport for the Tor Network. We aim to support dialing and listening.
Dialing
The first version assumes a Tor Server is available on localhost and can accept SOCKS5 connections.
Listening
The first version assumes a Tor Server is available and Onion Services are configured to redirect traffic to TCP connections which the peer will be listening on.