This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
Waku version 0 - initial #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added * sections * changelog * updated * updates * Update README.md
11 tasks
Co-Authored-By: kdeme <kim.demey@gmail.com>
decanus
reviewed
Nov 21, 2019
Co-Authored-By: kdeme <kim.demey@gmail.com>
|
Updated some stuff. Biggest change is probably the ABNF format to make data layout more concise, consistent and formal. |
|
@adambabik can you please provide the additional message codes? Which are optional? |
|
Alright, I think this PR is getting to be quite big and it's quite hard to follow the discussion. I suggest we aim to merge this as soon as possible, and mark any additional needs in one of the following ways:
@kdeme @adambabik @decanus @cammellos please take another look, give final suggestions (or do one of the three above) and let's get this thing merged. |
oskarth
commented
Nov 21, 2019
cammellos
approved these changes
Nov 21, 2019
kdeme
approved these changes
Nov 21, 2019
kdeme
pushed a commit
that referenced
this pull request
May 18, 2020
* Init with EIP-627 * Header and abstract * WIP * Update waku.md * Update waku.md * Inline comments * add Dean and toc * document rlpx subprotocol * Rename waku.md to waku/README.md * reworded * light-node (#31) * added * sections * changelog * updated * updates * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update RLPx subprotocol based on nim-eth changes * Add section on backwards compatibility * changelog and todo * update toc * update rlpx section * specify rlpx version number * add differences shh6 waku 0 * generalize light node section to additional capabilities * add mock security considerations section * mock section of forwards comp * bump mini version * fix typo * Update waku/README.md Co-Authored-By: kdeme <kim.demey@gmail.com> * Update waku/README.md Co-Authored-By: kdeme <kim.demey@gmail.com> * Update README.md * Update README.md * Update waku/README.md Co-Authored-By: kdeme <kim.demey@gmail.com> * Update README.md * Update README.md * Update README.md * Update waku/README.md Co-Authored-By: Adam Babik <a.babik@designfortress.com> * Update README.md * Update README.md * Update waku/README.md Co-Authored-By: kdeme <kim.demey@gmail.com> * Update waku/README.md Co-Authored-By: kdeme <kim.demey@gmail.com> * Update README.md (#42) * Move back to waku.md KISS * try footnote link * rlp detail links * add ABNF spec * moar abnf, and remove superfluous data format descriptions * modify abstract and motivation * abnf whisper envelope * move security consider * clarify duplication * some backwards compatibility notes and move things a bit * version 0.1.0 prepare for merge; toc; ack section * tweak acks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waku v0 #27