-
Notifications
You must be signed in to change notification settings - Fork 15
feat(60/STATUS-URL-SCHEME): initial draft #602
Conversation
Cannot add reviewers, so please |
This is very raw, little context or information is provided in the RFC. |
|
||
# References | ||
|
||
- [59/STATUS-URL-DATA](/spec/59/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #600
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reference should be used somewhere in the text.
I assume /59 specifies the encoding which is used to encode the URL scheme specified in this doc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very raw
@fryorcraken and what do you suggest?
- Merge it with feat(59/STATUS-URL-DATA): initial draft #600?
- Extend it for deep link implementations after
a. Use https:// deep links instead of status-im:// - Windows status-im/status-desktop#9549
b. Use https:// deep links instead of status-im:// - MacOS status-im/status-desktop#7957
c. Make deep links work for Linux status-im/status-desktop#8027 - Else?
This should grow with more paths being supported post MVP, and personally I wouldn't mind keeping it separate, simple and serve more as an overview with references.
content/docs/rfcs/60/README.md
Outdated
| Name | Url | Description | | ||
| ----- | ---- | ---- | | ||
| User profile | `/u/<data>#<signature>` | Preview/Open user profile | | ||
| | `/u#<compressed_user_public_key>` | | | ||
| | `/u#<ens_name>` | | | ||
| Community | `/c/<data>#<signature>` | Preview/Open community | | ||
| | `/c#<compressed_community_public_key>` | | | ||
| Community channel | `/cc/<data>#<signature>`| Preview/Open community channel | | ||
| | `/cc/<channel_uuid>#<compressed_community_public_key>` | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Name | Url | Description | | |
| ----- | ---- | ---- | | |
| User profile | `/u/<data>#<signature>` | Preview/Open user profile | | |
| | `/u#<compressed_user_public_key>` | | | |
| | `/u#<ens_name>` | | | |
| Community | `/c/<data>#<signature>` | Preview/Open community | | |
| | `/c#<compressed_community_public_key>` | | | |
| Community channel | `/cc/<data>#<signature>`| Preview/Open community channel | | |
| | `/cc/<channel_uuid>#<compressed_community_public_key>` | | | |
| Name | Url | Description | | |
| ----- | ---- | ---- | | |
| User profile | `/u/<encoded_data>#<encoded_signature_and_user_chat_key>` | Preview/Open user profile | | |
| | `/u#<user_chat_key>` | | | |
| | `/u#<ens_name>` | | | |
| Community | `/c/< encoded_data >#<encoded_signature_and_community_chat_key>` | Preview/Open community | | |
| | `/c#<community_chat_key>` | | | |
| Community channel | `/cc/< encoded_data >#< encoded_signature_and_community_chat_key >`| Preview/Open community channel | | |
| | `/cc/<channel_uuid>#<community_chat_key>` | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<encoded_signature_and_community_chat_key>
instead of <signature>
done in
status-im/status-web@d630006#diff-67f802f9ab57f928747d93bf45b7dbc9062af282d8e39e496c4d4ad5ad97dd0c
because
status-im/status-web@f0e59b3#diff-4c64b597af17789d552f8acb35dfc18def8c8c09dbff90f2548d91357ee272df
reported in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if other implementations can prove this change is redundant, please let me know asap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Felicio Mununga <felicio@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @fryorcraken , this spec would need more context.
Afaict, it can stay a separate RFC.
I should specify deep links, but not OS specific implementation details.
You could mention implementation suggestions.
serve more as an overview with references.
In this case, the document should be Informational
.
However, from what I understood so far, it would make sense to keep it as Standards Track
,
and specify the URL scheme for deep linking content.
(my feeback on /59 is similar, also lacks context)
slug: 60 | ||
title: 60/STATUS-URL-SCHEME | ||
name: Status URL Scheme | ||
status: draft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
status: draft | |
status: raw |
### Related scope | ||
|
||
#### Features | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These features would need more context. E.g. what is an onboarding website, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
# Abstract | ||
|
||
This document describes URL scheme for previewing and deep linking content as well as for triggering actions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This document describes URL scheme for previewing and deep linking content as well as for triggering actions. | |
This document specifies an URL scheme for previewing and deep linking content as well as for triggering actions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming this RFC is planned to grow into a normative specification.
|
||
# References | ||
|
||
- [59/STATUS-URL-DATA](/spec/59/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reference should be used somewhere in the text.
I assume /59 specifies the encoding which is used to encode the URL scheme specified in this doc?
content/docs/rfcs/60/README.md
Outdated
| Name | Url | Description | | ||
| ----- | ---- | ---- | | ||
| User profile | `/u/<encoded_data>#<encoded_signature_and_user_chat_key>` | Preview/Open user profile | | ||
| | `/u#<user_chat_key>` | | | ||
| | `/u#<ens_name>` | | | ||
| Community | `/c/< encoded_data >#<encoded_signature_and_community_chat_key>` | Preview/Open community | | ||
| | `/c#<community_chat_key>` | | | ||
| Community channel | `/cc/< encoded_data >#< encoded_signature_and_community_chat_key >`| Preview/Open community channel | | ||
| | `/cc/<channel_uuid>#<community_chat_key>` | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Name | Url | Description | | |
| ----- | ---- | ---- | | |
| User profile | `/u/<encoded_data>#<encoded_signature_and_user_chat_key>` | Preview/Open user profile | | |
| | `/u#<user_chat_key>` | | | |
| | `/u#<ens_name>` | | | |
| Community | `/c/< encoded_data >#<encoded_signature_and_community_chat_key>` | Preview/Open community | | |
| | `/c#<community_chat_key>` | | | |
| Community channel | `/cc/< encoded_data >#< encoded_signature_and_community_chat_key >`| Preview/Open community channel | | |
| | `/cc/<channel_uuid>#<community_chat_key>` | | | |
| Name | Url | Description | | |
| ----- | ---- | ---- | | |
| User profile | `/u/<encoded_data>#<user_chat_key>` | Preview/Open user profile | | |
| | `/u#<user_chat_key>` | | | |
| | `/u#<ens_name>` | | | |
| Community | `/c/<encoded_data>#<community_chat_key>` | Preview/Open community | | |
| | `/c#<community_chat_key>` | | | |
| Community channel | `/cc/<encoded_data>#<community_chat_key >`| Preview/Open community channel | | |
| | `/cc/<channel_uuid>#<community_chat_key>` | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See status-im/status-web#459 as to why.
Continue discussion: vacp2p/rfc-index#14 |
Moved from status-im/specs#159