Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

57/STATUS-Simple-Scaling: Short Summary #633

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Conversation

jimstir
Copy link
Contributor

@jimstir jimstir commented Nov 29, 2023

This document describes how to scale 56/STATUS-COMMUNITIES as well as 55/STATUS-1TO1-CHAT using existing Waku v2 protocols and components.

@jimstir jimstir marked this pull request as draft November 29, 2023 22:14
@jimstir jimstir requested a review from kaiserd November 29, 2023 22:14
@jimstir
Copy link
Contributor Author

jimstir commented Nov 29, 2023

@kaiserd this abstract display two COSS format specs and link to them. Is this good for the short summary?

Copy link
Contributor

@kaiserd kaiserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the description.

The reference changes should be reverted though.

@@ -5,16 +5,16 @@ name: Status Simple Scaling
status: raw
category: Informational
tags: waku/application
editor: Daniel Kaiser <danielkaiser@status.im>
description: Describes how to scale Status Communities and Status 1-to-1 Chat using existing Waku v2 protocols and components.
editor: Jimmy Debe <jimmy@status.im>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, please do not change the editors of RFCs that were already under Vac org. (Only put yourself as an editor for the RFCs that you ported from status.im to Vac org).

This document describes how to scale [56/STATUS-COMMUNITIES](/spec/56/) as well as [55/STATUS-1TO1-CHAT](/spec/55/)
using existing Waku v2 protocols and components.
It also adds a few new aspects, where more sophisticated components are not yet researched and evaluated.
This document describes how to scale [56/STATUS-COMMUNITIES](https://rfc.vac.dev/spec/56/) as well as [55/STATUS-1TO1-CHAT](https://rfc.vac.dev/spec/55/) using existing Waku v2 protocols and components. It also adds a few new aspects, where more sophisticated components are not yet researched and evaluated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove sembr here?
Please revert this back to a sembr.

[56/STATUS-COMMUNITIES](/spec/56/) as well as [55/STATUS-1TO1-CHAT](/spec/55/) use Waku v2 protocols.
Both use Waku content topics (see [23/WAKU2-TOPICS](/spec/23/)) for content based filtering.

[56/STATUS-COMMUNITIES](https://rfc.vac.dev/spec/56/) as well as [55/STATUS-1TO1-CHAT](https://rfc.vac.dev/spec/55/) use Waku v2 protocols.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert these changes. Specs should be referenced relatively.
This is how all refs to Vac RFCs should look like:
56/STATUS-COMMUNITIES

Copy link
Contributor

@kaiserd kaiserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you :)

@jimstir jimstir requested a review from kaiserd December 4, 2023 15:26
@kaiserd kaiserd marked this pull request as ready for review December 4, 2023 15:27
@jimstir jimstir merged commit e806798 into master Dec 4, 2023
@jimstir jimstir deleted the 57-status-simple-scaling branch December 4, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants