Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

56/STATUS-COMMUNITIES: Short Summary #639

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Conversation

jimstir
Copy link
Contributor

@jimstir jimstir commented Nov 29, 2023

Describes how Status Communities allow multiple users to communicate in a group chat. This is a key feature for the Status app.

@jimstir jimstir requested a review from kaiserd November 29, 2023 22:40
@jimstir jimstir marked this pull request as draft November 29, 2023 22:40
Copy link
Contributor

@kaiserd kaiserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description is good :). Thanks.

Please revert links and editor.

@@ -5,25 +5,26 @@ name: Status Communities that run over Waku v2
status: draft
category: Standards Track
tags: waku-application
editor: Aaryamann Challani <aaryamann@status.im>
description: Status Communities allow multiple users to communicate in a group chat. This is a key feature for the Status application.
editor: Jimmy Debe <jimmy@status.im>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here as for other RFCs, as discussed in the last meeting. Aaryamann ported that spec initially. Please revert.
(Will discuss this again in today's meeting.)

@jimstir jimstir requested a review from kaiserd December 4, 2023 15:02
@jimstir jimstir marked this pull request as ready for review December 4, 2023 15:02
Copy link
Contributor

@kaiserd kaiserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you :)

@jimstir jimstir merged commit 4d2da73 into master Dec 4, 2023
@jimstir jimstir deleted the 56-status-communities branch December 4, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants