1/COSS: Proposal Add Github Usernames #644
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felicio
reviewed
Dec 12, 2023
content/docs/rfcs/template/README.md
Outdated
| @@ -5,7 +5,7 @@ name: (Waku v2 | Logos | Codex) RFC Template | |||
| status: (raw|draft|stable) | |||
| category: (Standards Track|Informational|Best Current Practice) | |||
| tags: an optional list of tags, not standard | |||
| editor: Daniel Kaiser <danielkaiser@status.im> | |||
| editor: Daniel Kaiser <https://github.com/kaiserd> | |||
There was a problem hiding this comment.
OP: #641 (comment)
and what I'd propose, for example
Suggested change
| editor: Daniel Kaiser <https://github.com/kaiserd> | |
| editor: John Doe <johndoe@status.im> johndoe |
as
name [<email>] [gh handle]
kinda like comment on a ssh key instead of drooping the email altogether
There was a problem hiding this comment.
@felicio sorry, changed to correct proposal
There was a problem hiding this comment.
@jimstir you don't have to apologize 😅, it's just something I've just suggested 🙂.
There was a problem hiding this comment.
@felicio you can add other relevant reviewers
There was a problem hiding this comment.
@jimstir I can't, I don't have the rights on this repo 🙂
|
Continue discussion: vacp2p/rfc-index#4. The RFC process has been changed separating raw specs and the draft/stable specs into different repositories. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to add github usernames for editors and contributors along with emails.