fix: constraint on bn254 values #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
force-pushed
the
constraint-id-comms
branch
from
3b50f0c
to
cca45ef
Compare
LCOV of commit
|
0x-r4bbit
reviewed
Aug 16, 2023
| @@ -10,7 +10,7 @@ import "forge-std/console.sol"; | |||
|
|
|||
| contract RlnApp is RlnBase { | |||
| uint256 public constant allowedIdCommitment = | |||
| 21888242871839275222246405745257275088548364400416034343698204186575808495617; | |||
| 19014214495641488759237505126948346942972912379615652741039992445865937985820; | |||
There was a problem hiding this comment.
Why exactly has this been changed?
There was a problem hiding this comment.
Because it was earlier the order of the field, i.e p = 21888242871839275222246405745257275088548364400416034343698204186575808495617, and no number in the field can exceed it. switched it out to make sure people dont get confused about it
| uint256 badDepositAmount = MEMBERSHIP_DEPOSIT - 1; | ||
| vm.expectRevert(abi.encodeWithSelector(InsufficientDeposit.selector, MEMBERSHIP_DEPOSIT, badDepositAmount)); | ||
| rln.register{value: badDepositAmount}(idCommitment); | ||
| } | ||
|
|
||
| function test__InvalidRegistration__FullSet(uint256 idCommitmentSeed) public { | ||
| vm.assume(idCommitmentSeed < 2 ** 255 - SET_SIZE); | ||
| function test__InvalidRegistration__FullSet() public { |
There was a problem hiding this comment.
Just for me to understand: why did we move away from a fuzz test here? Has anything changed with regards to the seed that we can't/aren't relying on it anymore?
There was a problem hiding this comment.
technically we are not testing any logic here, we're just checking if an error is thrown based on the size of the tree - thats why we dont need to fuzz id commitments here
LCOV of commit
|
LCOV of commit
|
0x-r4bbit
approved these changes
Aug 16, 2023
This was referenced Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses waku-org#3 (comment)