Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6/WAKU1: Document the rest of Whisper packets #71

Open
4 tasks
adambabik opened this issue Dec 8, 2019 · 6 comments
Open
4 tasks

6/WAKU1: Document the rest of Whisper packets #71

adambabik opened this issue Dec 8, 2019 · 6 comments
Projects
vac-research

Comments

@adambabik
Copy link

adambabik commented Dec 8, 2019 •
edited by decanus

Problem

Not all packets are currently covered by the spec.

  • 11 Batch Ack
  • 12 Message Response
  • 123 P2P Sync Request
  • 124 P2P Sync Response

Acceptance criteria

Align with the PR status-im/specs#72.
@oskarth
Copy link
Member

oskarth commented Dec 16, 2019

What's the state of this @adambabik and @decanus?

@adambabik
Copy link
Author

Need to port status-im/specs#72.

This was referenced Dec 16, 2019
Merged
Closed
@decanus
Copy link
Contributor

decanus commented Dec 17, 2019

@adambabik it looks like the ones which aren't ported are packet codes that are marked as TODO in the spec.

@oskarth
Copy link
Member

oskarth commented Jan 14, 2020

@adambabik @decanus Is this issue still relevant? Given discussion yesterday, can we update this issue?

@decanus
Copy link
Contributor

decanus commented Jan 14, 2020

@oskarth it looks like most of them still need to be ported.

@oskarth oskarth changed the title Document the rest of Whisper packets 6/WAKU-1: Document the rest of Whisper packets Mar 31, 2021
@oskarth oskarth changed the title 6/WAKU-1: Document the rest of Whisper packets 6/WAKU1: Document the rest of Whisper packets Mar 31, 2021
@oskarth
Copy link
Member

oskarth commented Mar 31, 2021

6/WAKU1 spec not priority, PRs welcome though

@oskarth oskarth added this to New in vac-research Jul 14, 2021
@oskarth oskarth closed this as completed Jul 14, 2021
vac-research automation moved this from New to Done Jul 14, 2021
@oskarth oskarth reopened this Jul 14, 2021
vac-research automation moved this from Done to In progress Jul 14, 2021
@oskarth oskarth moved this from In progress to Icebox in vac-research Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
vac-research
Icebox
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adambabik @oskarth @decanus