Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discv5 #129

Merged
merged 56 commits into from
Jul 30, 2023
Merged

Discv5 #129

merged 56 commits into from
Jul 30, 2023

Conversation

AlbertoSoutullo
Copy link
Collaborator

@AlbertoSoutullo AlbertoSoutullo commented Jun 9, 2023

Discv5 now works on simulations. Kurtosis can't modify dinamically created files. So the option of integrating Gennet in Kurtosis is not viable.

Also, we need the ENR of the bootstrap node before instantiating all other nodes, since this is a parameter that can only be set up when you first run the node.

To solve this, in run.sh we add a boostrap node to the enclave in a similar way we add cAdvisor. Then, we query the node to get its ENR, and then we modify the discv5 template, so if discv5 is used, this ENR will be passed to all nodes that will use it.

Summary of changes:

  • Added bootstrap node to work with Discv5
  • Discv5 trait can be correctly enabled now
  • Added new flag to skip interconnection phase in Kurtosis
  • Updated Tests
  • Commented gowaku tests until gowaku is fully integrated

Closes #123 , closes #120 , closes #118 , closes #78

…arlark does not substitute future references in json.decode
@AlbertoSoutullo AlbertoSoutullo added enhancement New feature or request Kurtosis labels Jun 9, 2023
@AlbertoSoutullo AlbertoSoutullo self-assigned this Jun 9, 2023
@AlbertoSoutullo AlbertoSoutullo marked this pull request as ready for review June 12, 2023 11:56
@Daimakaimura
Copy link
Contributor

Looks good. Is Discv5 enabled by default? I want to try this but I m not sure if there is anything else that I need to do

@AlbertoSoutullo
Copy link
Collaborator Author

  • be correctly enabled now

You have to set it in the gennet traits configuration. But the bootstrapnode will be prepared beforehand yes.
I wanted to make a check to activate it depending on if we used that trait or not, but the way traits are handled by gennet makes it a bit messy. So a bootstrap node will be instantiated by default. Then, if you put discv5 in gennet traits, they will connect to it directly. You can use the flag "interconnect_nodes" to skip or not the topology connection.

And now I just realized I didn't update some stuff I wanted to do, let me put this as draft for 30 minutes, then I will comment again when this is ready. My bad.

@AlbertoSoutullo AlbertoSoutullo merged commit be18041 into master Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Kurtosis
Projects
None yet
2 participants