Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use pmtree instead of vacp2p_pmtree #203

Merged
merged 1 commit into from
Aug 16, 2023
Merged

chore: use pmtree instead of vacp2p_pmtree #203

merged 1 commit into from
Aug 16, 2023

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Aug 16, 2023

Now that the changes we require are upstream, using pmtree's crate

@github-actions
Copy link

Benchmark for 0941720

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1217.9±2.30ns 1217.0±2.26ns -0.07%
FullMerkleTree::get 0.1±0.00ns 0.1±0.00ns 0.00%
FullMerkleTree::override_range 3.0±0.00µs 3.0±0.00µs 0.00%
FullMerkleTree::set 1219.5±1.64ns 1218.5±1.78ns -0.08%
OptimalMerkleTree::compute_root 1431.5±62.76ns 1410.7±2.51ns -1.45%
OptimalMerkleTree::delete 1418.2±1.88ns 1396.3±1.51ns -1.54%
OptimalMerkleTree::get 30.4±0.06ns 30.6±0.05ns +0.66%
OptimalMerkleTree::override_range 7.0±0.00µs 7.1±0.01µs +1.43%
OptimalMerkleTree::set 1379.3±2.13ns 1373.8±3.39ns -0.40%

@github-actions
Copy link

Benchmark for 0941720

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.5±0.06ns 2.0±0.01ns -20.00%
Pmtree::get 565.5±0.77ns 571.0±20.21ns +0.97%
Pmtree::override_range 216.8±24.73µs 223.4±27.46µs +3.04%
Pmtree::set 78.7±0.55µs 79.5±0.61µs +1.02%
Pmtree:delete 80.1±2.34µs 79.6±0.15µs -0.62%

@rymnc rymnc merged commit bf3d1d3 into master Aug 16, 2023
17 checks passed
@rymnc rymnc deleted the upstream-patch branch August 16, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant