Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rln): use config.open instead of sled::open #208

Closed
wants to merge 1 commit into from
Closed

fix(rln): use config.open instead of sled::open #208

wants to merge 1 commit into from

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Aug 24, 2023

By using sled::open, we default to sled db's default config, which prevents us from opening the tree, thereby recreating it

@rymnc rymnc self-assigned this Aug 24, 2023
@rymnc rymnc added the track:rln RLN Track - (Secure Messaging/Applied ZK), relay and applications label Aug 24, 2023
@rymnc rymnc marked this pull request as ready for review August 24, 2023 18:04
@rymnc rymnc mentioned this pull request Aug 24, 2023
Closed
@github-actions
Copy link

Benchmark for 46ec47f

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1247.8±3.21ns 1256.4±0.69ns +0.69%
FullMerkleTree::get 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::override_range 3.1±0.00µs 3.1±0.00µs 0.00%
FullMerkleTree::set 1248.4±4.86ns 1248.2±1.10ns -0.02%
OptimalMerkleTree::compute_root 1390.3±0.74ns 1391.5±0.67ns +0.09%
OptimalMerkleTree::delete 1383.0±1.21ns 1378.6±1.04ns -0.32%
OptimalMerkleTree::get 29.7±0.02ns 29.1±0.02ns -2.02%
OptimalMerkleTree::override_range 7.0±0.00µs 7.0±0.01µs 0.00%
OptimalMerkleTree::set 1398.5±1.13ns 1428.9±14.26ns +2.17%

@github-actions
Copy link

Benchmark for 46ec47f

Click to view benchmark
Test Base PR %
Pmtree::compute_root 1.7±0.00ns 1.7±0.00ns 0.00%
Pmtree::get 458.6±0.52ns 478.5±0.32ns +4.34%
Pmtree::override_range 188.1±109.66µs 180.6±16.89µs -3.99%
Pmtree::set 66.5±0.06µs 66.2±0.05µs -0.45%
Pmtree:delete 66.2±0.11µs 65.8±0.06µs -0.60%

@github-actions
Copy link

Benchmark for d167937

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1457.6±25.93ns 1482.8±20.59ns +1.73%
FullMerkleTree::get 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::override_range 3.7±0.05µs 3.7±0.07µs 0.00%
FullMerkleTree::set 1473.3±24.72ns 1482.9±22.27ns +0.65%
OptimalMerkleTree::compute_root 1650.4±29.46ns 1650.7±18.78ns +0.02%
OptimalMerkleTree::delete 1647.4±26.72ns 1648.8±19.97ns +0.08%
OptimalMerkleTree::get 35.0±0.88ns 34.7±0.47ns -0.86%
OptimalMerkleTree::override_range 8.3±0.17µs 8.2±0.28µs -1.20%
OptimalMerkleTree::set 1648.0±45.66ns 1649.7±18.35ns +0.10%

@github-actions
Copy link

Benchmark for d167937

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.0±0.00ns 2.0±0.00ns 0.00%
Pmtree::get 487.1±0.48ns 479.1±0.31ns -1.64%
Pmtree::override_range 169.9±8.82µs 172.2±20.30µs +1.35%
Pmtree::set 68.5±0.04µs 67.2±0.05µs -1.90%
Pmtree:delete 67.7±0.07µs 67.8±0.03µs +0.15%

@github-actions
Copy link

Benchmark for 3115ffb

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1536.8±46.07ns 1521.3±77.30ns -1.01%
FullMerkleTree::get 0.1±0.00ns 0.1±0.00ns 0.00%
FullMerkleTree::override_range 3.9±0.11µs 3.8±0.13µs -2.56%
FullMerkleTree::set 1546.8±78.93ns 1537.2±113.87ns -0.62%
OptimalMerkleTree::compute_root 1750.8±72.79ns 1705.7±42.19ns -2.58%
OptimalMerkleTree::delete 1738.9±73.93ns 1705.4±46.58ns -1.93%
OptimalMerkleTree::get 37.9±3.82ns 37.1±1.06ns -2.11%
OptimalMerkleTree::override_range 8.9±0.27µs 8.6±0.24µs -3.37%
OptimalMerkleTree::set 1736.4±37.94ns 1689.5±33.53ns -2.70%

@github-actions
Copy link

Benchmark for 3115ffb

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.0±0.01ns 2.0±0.01ns 0.00%
Pmtree::get 556.8±0.98ns 556.6±1.36ns -0.04%
Pmtree::override_range 208.2±7.33µs 210.5±13.01µs +1.10%
Pmtree::set 79.1±0.17µs 79.4±0.12µs +0.38%
Pmtree:delete 79.3±0.07µs 79.4±0.06µs +0.13%

@github-actions
Copy link

Benchmark for 0c731c0

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1233.0±82.80ns 1239.9±96.78ns +0.56%
FullMerkleTree::get 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::override_range 3.1±0.19µs 3.2±0.23µs +3.23%
FullMerkleTree::set 1221.3±62.58ns 1234.3±80.08ns +1.06%
OptimalMerkleTree::compute_root 1380.5±68.17ns 1394.2±71.86ns +0.99%
OptimalMerkleTree::delete 1398.3±87.97ns 1394.6±109.67ns -0.26%
OptimalMerkleTree::get 30.3±1.84ns 32.9±1.78ns +8.58%
OptimalMerkleTree::override_range 6.9±0.35µs 6.9±0.39µs 0.00%
OptimalMerkleTree::set 1433.2±94.91ns 1393.1±91.30ns -2.80%

@github-actions
Copy link

Benchmark for 0c731c0

Click to view benchmark
Test Base PR %
Pmtree::compute_root 1.7±0.00ns 2.0±0.03ns +17.65%
Pmtree::get 461.7±2.04ns 464.8±0.25ns +0.67%
Pmtree::override_range 172.5±9.88µs 177.6±11.54µs +2.96%
Pmtree::set 67.0±0.12µs 68.9±0.20µs +2.84%
Pmtree:delete 66.2±0.08µs 68.9±0.07µs +4.08%

@github-actions
Copy link

Benchmark for c964a5e

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1208.6±1.29ns 1211.9±2.63ns +0.27%
FullMerkleTree::get 0.1±0.00ns 0.1±0.00ns 0.00%
FullMerkleTree::override_range 3.0±0.00µs 3.1±0.00µs +3.33%
FullMerkleTree::set 1219.9±1.56ns 1206.7±1.92ns -1.08%
OptimalMerkleTree::compute_root 1398.5±3.95ns 1399.0±1.76ns +0.04%
OptimalMerkleTree::delete 1386.1±1.34ns 1391.3±1.61ns +0.38%
OptimalMerkleTree::get 30.6±0.08ns 31.3±0.10ns +2.29%
OptimalMerkleTree::override_range 7.1±0.01µs 7.1±0.01µs 0.00%
OptimalMerkleTree::set 1377.4±1.26ns 1430.5±24.04ns +3.86%

@github-actions
Copy link

Benchmark for c964a5e

Click to view benchmark
Test Base PR %
Pmtree::compute_root 1.6±0.00ns 1.6±0.00ns 0.00%
Pmtree::get 471.9±0.26ns 495.2±0.49ns +4.94%
Pmtree::override_range 165.3±5.62µs 168.2±10.22µs +1.75%
Pmtree::set 68.7±0.04µs 66.5±0.53µs -3.20%
Pmtree:delete 67.8±0.08µs 68.0±0.41µs +0.29%

@github-actions
Copy link

Benchmark for 81d43d4

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1491.6±0.87ns 1483.6±7.79ns -0.54%
FullMerkleTree::get 0.1±0.00ns 0.0±0.00ns -100.00%
FullMerkleTree::override_range 3.8±0.01µs 3.7±0.02µs -2.63%
FullMerkleTree::set 1493.7±9.59ns 1491.2±5.91ns -0.17%
OptimalMerkleTree::compute_root 1657.9±12.14ns 1660.1±5.58ns +0.13%
OptimalMerkleTree::delete 1657.9±7.99ns 1643.5±12.66ns -0.87%
OptimalMerkleTree::get 34.8±0.14ns 34.2±0.24ns -1.72%
OptimalMerkleTree::override_range 8.4±0.11µs 8.4±0.06µs 0.00%
OptimalMerkleTree::set 1665.7±40.88ns 1640.2±21.11ns -1.53%

@github-actions
Copy link

Benchmark for 81d43d4

Click to view benchmark
Test Base PR %
Pmtree::compute_root 1.7±0.00ns 2.0±0.02ns +17.65%
Pmtree::get 459.0±0.28ns 462.5±0.36ns +0.76%
Pmtree::override_range 175.6±7.84µs 187.3±14.62µs +6.66%
Pmtree::set 67.4±0.04µs 66.0±0.95µs -2.08%
Pmtree:delete 66.4±0.06µs 67.1±0.05µs +1.05%

@github-actions
Copy link

Benchmark for 9c32e3f

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1584.6±72.01ns 1491.6±98.69ns -5.87%
FullMerkleTree::get 0.1±0.00ns 0.0±0.00ns -100.00%
FullMerkleTree::override_range 4.0±0.16µs 3.9±0.61µs -2.50%
FullMerkleTree::set 1626.5±102.62ns 1484.7±66.06ns -8.72%
OptimalMerkleTree::compute_root 1817.5±103.92ns 1707.0±161.92ns -6.08%
OptimalMerkleTree::delete 1779.7±115.88ns 1715.5±145.36ns -3.61%
OptimalMerkleTree::get 37.7±3.46ns 36.4±1.83ns -3.45%
OptimalMerkleTree::override_range 8.8±0.47µs 8.6±1.30µs -2.27%
OptimalMerkleTree::set 1905.0±146.38ns 1732.8±114.42ns -9.04%

@github-actions
Copy link

Benchmark for 9c32e3f

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.4±0.06ns 2.8±0.12ns +16.67%
Pmtree::get 576.9±16.86ns 567.4±22.46ns -1.65%
Pmtree::override_range 251.4±18.92µs 260.0±46.50µs +3.42%
Pmtree::set 85.6±2.44µs 83.5±3.71µs -2.45%
Pmtree:delete 86.2±7.03µs 84.3±3.43µs -2.20%

@github-actions
Copy link

Benchmark for 3003ddf

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1213.5±1.80ns 1213.3±2.47ns -0.02%
FullMerkleTree::get 0.1±0.00ns 0.1±0.00ns 0.00%
FullMerkleTree::override_range 3.1±0.00µs 3.0±0.00µs -3.23%
FullMerkleTree::set 1212.6±9.40ns 1206.2±2.69ns -0.53%
OptimalMerkleTree::compute_root 1414.3±2.31ns 1406.4±1.86ns -0.56%
OptimalMerkleTree::delete 1399.0±1.03ns 1391.6±1.97ns -0.53%
OptimalMerkleTree::get 33.0±0.11ns 31.5±0.11ns -4.55%
OptimalMerkleTree::override_range 7.1±0.02µs 7.1±0.03µs 0.00%
OptimalMerkleTree::set 1373.5±1.30ns 1395.6±2.37ns +1.61%

@github-actions
Copy link

Benchmark for 3003ddf

Click to view benchmark
Test Base PR %
Pmtree::compute_root 9.0±0.00ns 1.7±0.00ns -81.11%
Pmtree::get 470.7±0.25ns 456.9±0.25ns -2.93%
Pmtree::override_range 177.0±8.33µs 172.5±8.75µs -2.54%
Pmtree::set 66.8±0.07µs 66.3±0.09µs -0.75%
Pmtree:delete 66.1±0.07µs 65.5±0.05µs -0.91%

@rymnc rymnc force-pushed the v0.3.2 branch 2 times, most recently from 54a28ad to 14fa7bf Compare August 24, 2023 22:39
@rymnc
Copy link
Contributor Author

rymnc commented Aug 25, 2023

Closing in favor of #209

@rymnc rymnc closed this Aug 25, 2023
@rymnc rymnc deleted the v0.3.2 branch August 25, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rymnc rymnc

Labels
track:rln RLN Track - (Secure Messaging/Applied ZK), relay and applications
Projects
Vac Research
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rymnc