Remove height 32 from RLN #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for a70d395Click to view benchmark
|
Benchmark for a70d395Click to view benchmark
|
rymnc
requested changes
Apr 22, 2024
rln/src/circuit.rs
Outdated
| @@ -33,8 +33,8 @@ const WASM_FILENAME: &str = "rln.wasm"; | |||
| // Note that the circuit and keys in TEST_RESOURCES_FOLDER are compiled for Merkle trees of height 20 & 32 | |||
| // Changing these parameters to other values than these defaults will cause zkSNARK proof verification to fail | |||
| pub const TEST_PARAMETERS_INDEX: usize = 0; | |||
| pub const TEST_TREE_HEIGHT: usize = [20, 32][TEST_PARAMETERS_INDEX]; | |||
| pub const TEST_RESOURCES_FOLDER: &str = ["tree_height_20", "tree_height_32"][TEST_PARAMETERS_INDEX]; | |||
| pub const TEST_TREE_HEIGHT: usize = [20][TEST_PARAMETERS_INDEX]; | |||
There was a problem hiding this comment.
you should also remove the tree_height_32 resources from the resources sub-directory.
please fix the comments which reference the tree height 32 too.
we can remove the TEST_TREE_HEIGHT, TEST_PARAMETERS_INDEX constants since they can have only one value.
There was a problem hiding this comment.
Removed resources.
Removed TEST_PARAMETERS_INDEX , but left TEST_TREE_HEIGHT, because it is used all over the place, and removing it would make it less descriptive.
|
Please also add some description to your PR, and link back to the issue in which this was assigned to you |
|
Part of #237 |
Benchmark for f03469aClick to view benchmark
|
Done |
Benchmark for f03469aClick to view benchmark
|
rymnc
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove tree_height 32 resources and associated circuit loading within