Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rln-wasm): dont run benchmarks #241

Merged
merged 1 commit into from
Apr 30, 2024
Merged

fix(rln-wasm): dont run benchmarks #241

merged 1 commit into from
Apr 30, 2024

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Apr 30, 2024

  • fix(rln-wasm): dont run benchmarks

This PR excludes rln-wasm from default-members of the workspace and thereby allows cargo bench and cargo make bench to be ran from the root of the project.

thanks for the report @seemenkina

@rymnc rymnc self-assigned this Apr 30, 2024
@rymnc rymnc requested a review from seemenkina April 30, 2024 10:17
Copy link

Benchmark for 54ac42f

Click to view benchmark
Test Base PR %
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 319.3±4.08ns 323.9±3.76ns +1.44%
Pmtree::override_range 241.1±5.88µs 246.2±8.13µs +2.12%
Pmtree::set 56.0±1.09µs 56.1±0.75µs +0.18%
Pmtree:delete 56.1±1.06µs 56.1±0.95µs 0.00%

Copy link

Benchmark for 54ac42f

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 907.8±6.17ns 889.3±11.60ns -2.04%
FullMerkleTree::get 3.5±0.08ns 3.5±0.05ns 0.00%
FullMerkleTree::override_range 2.2±0.03µs 2.2±0.02µs 0.00%
FullMerkleTree::set 909.0±6.82ns 897.5±13.10ns -1.27%
OptimalMerkleTree::compute_root 1036.0±14.74ns 1055.3±9.91ns +1.86%
OptimalMerkleTree::delete 1028.5±15.82ns 1047.4±19.94ns +1.84%
OptimalMerkleTree::get 23.4±0.19ns 23.5±0.39ns +0.43%
OptimalMerkleTree::override_range 5.2±0.06µs 5.3±0.21µs +1.92%
OptimalMerkleTree::set 1029.1±8.24ns 1048.3±13.76ns +1.87%

Copy link

Benchmark for ae88d5a

Click to view benchmark
Test Base PR %
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 319.5±5.20ns 320.7±4.84ns +0.38%
Pmtree::override_range 241.0±7.92µs 244.5±3.26µs +1.45%
Pmtree::set 55.9±0.27µs 56.0±0.46µs +0.18%
Pmtree:delete 55.9±0.47µs 55.8±0.73µs -0.18%

Copy link

Benchmark for ae88d5a

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 897.0±15.94ns 887.1±11.89ns -1.10%
FullMerkleTree::get 3.4±0.17ns 3.4±0.05ns 0.00%
FullMerkleTree::override_range 2.2±0.04µs 2.2±0.04µs 0.00%
FullMerkleTree::set 885.5±12.92ns 883.2±9.81ns -0.26%
OptimalMerkleTree::compute_root 1041.9±14.86ns 1036.1±10.13ns -0.56%
OptimalMerkleTree::delete 1030.1±11.16ns 1029.8±22.01ns -0.03%
OptimalMerkleTree::get 23.4±0.40ns 23.2±0.30ns -0.85%
OptimalMerkleTree::override_range 5.3±0.04µs 5.2±0.10µs -1.89%
OptimalMerkleTree::set 1044.0±57.15ns 1026.6±7.25ns -1.67%

@rymnc rymnc merged commit 5937a67 into master Apr 30, 2024
10 checks passed
@rymnc rymnc deleted the rln-wasm-bench branch April 30, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants