Poseidon starky #16
Merged
Poseidon starky #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonesmarvin8
approved these changes
Oct 30, 2023
| } | ||
|
|
||
| let stark = S::default(); | ||
| let trace = generate_poseidon_trace(&step_rows); |
There was a problem hiding this comment.
This is Poseidon2. Poseidon2 for plonkish circuits should be taken into built in speed ups that are not present in Poseidon1. So, I'm not sure this benchmark would yield a fair comparison.
There was a problem hiding this comment.
Actually it's Poseidon. There were a couple naming typos, but the implementation in for Poseidon
moudyellaz
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.