Halo2 SHPLONK benchmark #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| use std::marker::PhantomData; | ||
| use std::path::Path; | ||
|
|
||
| pub mod application { |
There was a problem hiding this comment.
Lines 19-293 is mostly modified PSE code. Could this be shifted to a separate file (with credit provided)? As mentioned on halo2-gwc code, I'm not sure if we can use cargo to pull dependencies from a snark-verifier-sdk/example.
There was a problem hiding this comment.
Unfortunately it cannot
| [package] | ||
| name = "halo2-shplonk" | ||
| version = "0.1.0" | ||
| edition = "2021" |
There was a problem hiding this comment.
Year should be updated.
There was a problem hiding this comment.
What do you mean?
|
Note that I cannot fully execute the code on my machine. So, any suggestion can only be verifier by building the code and running it up to a point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.