Handle undefined pool info

vacuumlabs · Nov 22, 2021 · 87febcc · 87febcc
1 parent 5e21123
commit 87febcc
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/app/frontend/helpers/dataProviders/stakepoolDataProvider.ts b/app/frontend/helpers/dataProviders/stakepoolDataProvider.ts
@@ -19,8 +19,9 @@ const createStakepoolDataProvider = (
     [{}, {}]
   )
 
-  const getPoolInfoByTicker = (ticker: string): Stakepool => tickerMapping[ticker]
-  const getPoolInfoByPoolHash = (poolHash: string): Stakepool => poolHashMapping[poolHash]
+  const getPoolInfoByTicker = (ticker: string): Stakepool | null => tickerMapping[ticker] ?? null
+  const getPoolInfoByPoolHash = (poolHash: string): Stakepool | null =>
+    poolHashMapping[poolHash] ?? null
   const hasTickerMapping = Object.keys(tickerMapping).length !== 0
 
   return {

diff --git a/app/frontend/helpers/dataProviders/types.ts b/app/frontend/helpers/dataProviders/types.ts
@@ -1,7 +1,7 @@
 import {Stakepool} from '../../../frontend/types'
 
 export type StakepoolDataProvider = {
-  getPoolInfoByTicker: (ticker: string) => Stakepool
-  getPoolInfoByPoolHash: (poolHash: string) => Stakepool
+  getPoolInfoByTicker: (ticker: string) => Stakepool | null
+  getPoolInfoByPoolHash: (poolHash: string) => Stakepool | null
   hasTickerMapping: boolean
 }
diff --git a/app/frontend/wallet/blockchain-explorer.ts b/app/frontend/wallet/blockchain-explorer.ts
@@ -431,8 +431,10 @@ const blockchainExplorer = (ADALITE_CONFIG) => {
       if (stakePool?.name) {
         return stakePool
       }
-      const poolInfo = await getPoolInfo(stakePool.url)
-      return 'name' in poolInfo ? poolInfo : ({name: UNKNOWN_POOL_NAME} as HostedPoolMetadata)
+      const poolInfo = stakePool ? await getPoolInfo(stakePool.url) : null
+      return poolInfo && 'name' in poolInfo
+        ? poolInfo
+        : ({name: UNKNOWN_POOL_NAME} as HostedPoolMetadata)
     }
 
     const nextRewardDetailsWithMetaData: Array<RewardWithMetadata> = await Promise.all(