fix checkbox state and change github sign in button label

vacuumlabs · May 6, 2024 · 0d18a06 · 0d18a06
1 parent 6da54ae
commit 0d18a06
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/src/components/sections/GitHub/GithubFileSelect.tsx b/src/components/sections/GitHub/GithubFileSelect.tsx
@@ -35,7 +35,7 @@ const GithubFileSelect = ({
       <Button
         onClick={() => signIn('github')}
         className="bg-gray-800 text-white">
-        Sign in with Github to select repo files
+        Sign in with Github to select files
       </Button>
     )
   }
@@ -67,7 +67,7 @@ type FileTreeProps = {
   fileTree: GetRepoFilesResponse | undefined | null
   isLoading: boolean
   selectedFilePaths: string[]
-  onSelectFilePaths: (files: string[]) => void
+  onSelectFilePaths: (newFiles: string[]) => void
 }
 
 const FileTree = ({
@@ -84,10 +84,14 @@ const FileTree = ({
     checked: CheckedState,
     path: string | undefined,
   ) => {
+    if (!path) {
+      return
+    }
+
     if (checked) {
-      onSelectFilePaths(selectedFilePaths.filter((file) => file !== path))
+      onSelectFilePaths([...selectedFilePaths, path])
     } else {
-      onSelectFilePaths([...selectedFilePaths, path ?? ''])
+      onSelectFilePaths(selectedFilePaths.filter((file) => file !== path))
     }
   }
 

diff --git a/src/components/sections/GitHub/GithubRepoSelect.tsx b/src/components/sections/GitHub/GithubRepoSelect.tsx
@@ -24,7 +24,7 @@ const GithubRepoSelect = ({selectedRepo, onSelectRepo}: GithubRepoSelect) => {
       <Button
         onClick={() => signIn('github')}
         className="bg-gray-800 text-white">
-        Sign in with Github to select repo files
+        Sign in with Github to select a repo
       </Button>
     )
   }