type safety with enable

d option
vacuumlabs · May 6, 2024 · b271d9b · b271d9b
1 parent d3545f7
commit b271d9b
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 9 deletions.
diff --git a/src/components/sections/contest/GithubFileSelect.tsx b/src/components/sections/contest/GithubFileSelect.tsx
@@ -26,8 +26,7 @@ const GithubFileSelect = () => {
   const {data: publicReposData, isLoading: publicReposIsLoading} =
     useGetPublicRepos()
   const {data: repoFilesData, isLoading: repoFilesIsLoading} = useGetRepoFiles(
-    selectedRepo ?? {defaultBranch: '', owner: '', repo: ''},
-    {enabled: selectedRepo !== null},
+    selectedRepo ?? undefined,
   )
 
   if (session.data?.user.provider !== 'github') {

diff --git a/src/lib/queries/github/getGitHub.ts b/src/lib/queries/github/getGitHub.ts
@@ -21,12 +21,16 @@ export const useGetPublicRepos = () => {
   return useQuery({...getPublicReposQueryOptions(userId), enabled: !!userId})
 }
 
-const getRepoFilesQueryOptions = (params: GetRepoFilesParams) => ({
+const getRepoFilesQueryOptions = (params: GetRepoFilesParams | undefined) => ({
   queryKey: queryKeys.gitHub.repoFiles(params).queryKey,
-  queryFn: withApiErrorHandler(() => getRepoFiles(params)),
+  queryFn: withApiErrorHandler(() => {
+    if (!params) {
+      throw new Error('GetRepoFilesParams is required.')
+    }
+
+    return getRepoFiles(params)
+  }),
 })
 
-export const useGetRepoFiles = (
-  params: GetRepoFilesParams,
-  options?: {enabled?: boolean},
-) => useQuery({...options, ...getRepoFilesQueryOptions(params)})
+export const useGetRepoFiles = (params: GetRepoFilesParams | undefined) =>
+  useQuery({...getRepoFilesQueryOptions(params), enabled: !!params})
diff --git a/src/lib/queries/keys.ts b/src/lib/queries/keys.ts
@@ -21,6 +21,6 @@ export const queryKeys = createQueryKeyStore({
   },
   gitHub: {
     publicRepos: (userId: string | undefined) => [userId],
-    repoFiles: (params: GetRepoFilesParams) => [params],
+    repoFiles: (params: GetRepoFilesParams | undefined) => [params],
   },
 })