show no metadata msg

vacuumlabs · Oct 28, 2020 · 1a92fce · 1a92fce
1 parent 300bc1f
commit 1a92fce
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 8 deletions.
diff --git a/src/securityPolicy.c b/src/securityPolicy.c
@@ -296,6 +296,11 @@ security_policy_t policyForSignTxStakePoolRegistrationMetadata()
 	SHOW_IF(true);
 }
 
+security_policy_t policyForSignTxStakePoolRegistrationNoMetadata()
+{
+	SHOW_IF(true);
+}
+
 security_policy_t policyForSignTxStakePoolRegistrationConfirm()
 {
 	PROMPT_IF(true);

diff --git a/src/securityPolicy.h b/src/securityPolicy.h
@@ -51,6 +51,7 @@ security_policy_t policyForSignTxCertificateStakePoolRegistration(
 );
 security_policy_t policyForSignTxStakePoolRegistrationOwner(pool_owner_t* owner);
 security_policy_t policyForSignTxStakePoolRegistrationMetadata();
+security_policy_t policyForSignTxStakePoolRegistrationNoMetadata();
 security_policy_t policyForSignTxStakePoolRegistrationConfirm();
 
 security_policy_t policyForSignTxWithdrawal();

diff --git a/src/signTxPoolRegistration.c b/src/signTxPoolRegistration.c
@@ -576,7 +576,8 @@ static void signTxPoolRegistration_handleRelayAPDU(uint8_t* wireDataBuffer, size
 // ============================== METADATA ==============================
 
 enum {
-	HANDLE_METADATA_STEP_DISPLAY_URL = 6340,
+	HANDLE_METADATA_STEP_DISPLAY_NO_METADATA = 6340,
+	HANDLE_METADATA_STEP_DISPLAY_URL,
 	HANDLE_METADATA_STEP_DISPLAY_HASH,
 	HANDLE_METADATA_STEP_RESPOND,
 	HANDLE_METADATA_STEP_INVALID,
@@ -591,6 +592,14 @@ static void handleMetadata_ui_runStep()
 
 	UI_STEP_BEGIN(subctx->ui_step);
 
+	UI_STEP(HANDLE_METADATA_STEP_DISPLAY_NO_METADATA) {
+		UI_STEP_JUMP_AFTER_USER_INTERACTION(HANDLE_METADATA_STEP_RESPOND);
+		ui_displayPaginatedText(
+			"No metadata",
+			"(anonymous pool)",
+			this_fn
+		);
+	}
 	UI_STEP(HANDLE_METADATA_STEP_DISPLAY_URL) {
 		char metadataUrlStr[1 + POOL_METADATA_URL_MAX_LENGTH];
 		ASSERT(md->urlSize <= POOL_METADATA_URL_MAX_LENGTH);
@@ -630,6 +639,32 @@ enum {
 	POOL_CERTIFICATE_METADATA_YES = 2
 };
 
+static void handleNoMetadata()
+{
+	{
+		security_policy_t policy = policyForSignTxStakePoolRegistrationNoMetadata();
+		TRACE("Policy: %d", (int) policy);
+		ENSURE_NOT_DENIED(policy);
+
+		// select UI step
+		switch (policy) {
+#	define  CASE(POLICY, UI_STEP) case POLICY: {subctx->ui_step=UI_STEP; break;}
+			CASE(POLICY_SHOW_BEFORE_RESPONSE, HANDLE_METADATA_STEP_DISPLAY_NO_METADATA);
+			CASE(POLICY_ALLOW_WITHOUT_PROMPT, HANDLE_METADATA_STEP_RESPOND);
+#	undef   CASE
+		default:
+			THROW(ERR_NOT_IMPLEMENTED);
+		}
+	}
+	{
+		// add null metadata to certificate
+		TRACE("Adding null pool metadata to tx hash");
+		txHashBuilder_addPoolRegistrationCertificate_addPoolMetadata_null(txHashBuilder);
+	}
+
+	handleMetadata_ui_runStep();
+}
+
 static void signTxPoolRegistration_handlePoolMetadataAPDU(uint8_t* wireDataBuffer, size_t wireDataSize)
 {
 	{
@@ -657,13 +692,7 @@ static void signTxPoolRegistration_handlePoolMetadataAPDU(uint8_t* wireDataBuffe
 
 			if (includeMetadata == POOL_CERTIFICATE_METADATA_NO) {
 				VALIDATE(view_remainingSize(&view) == 0, ERR_INVALID_DATA);
-
-				// add null metadata to certificate
-				TRACE("Adding null pool metadata to tx hash");
-				txHashBuilder_addPoolRegistrationCertificate_addPoolMetadata_null(txHashBuilder);
-
-				respondSuccessEmptyMsg();
-				advanceState();
+				handleNoMetadata();
 				return;
 			} else {
 				VALIDATE(includeMetadata == POOL_CERTIFICATE_METADATA_YES, ERR_INVALID_DATA);