replace NULL returns with throws for scan-build

src/signTx.c

@@ -2266,7 +2266,7 @@ ins_sign_tx_aux_data_context_t* accessAuxDataContext()
 		#ifndef DEVEL
 		ASSERT(false);
 		#endif
-		return NULL;
+		THROW(ERR_ASSERT);
 	}
 }
 
@@ -2295,7 +2295,7 @@ ins_sign_tx_body_context_t* accessBodyContext()
 		#ifndef DEVEL
 		ASSERT(false);
 		#endif
-		return NULL;
+		THROW(ERR_ASSERT);
 	}
 }
 
@@ -2310,6 +2310,6 @@ ins_sign_tx_witness_context_t* accessWitnessContext()
 		#ifndef DEVEL
 		ASSERT(false);
 		#endif
-		return NULL;
+		THROW(ERR_ASSERT);
 	}
 }

src/signTx.h

@@ -213,15 +213,9 @@ ins_sign_tx_body_context_t* accessBodyContext();
 ins_sign_tx_witness_context_t* accessWitnessContext();
 
 
-#ifdef DEVEL
-#define AUX_DATA_CTX (ASSERT(accessAuxDataContext() != NULL), accessAuxDataContext())
-#define BODY_CTX (ASSERT(accessBodyContext() != NULL), accessBodyContext())
-#define WITNESS_CTX (ASSERT(accessWitnessContext() != NULL), accessWitnessContext())
-#else
 #define AUX_DATA_CTX (accessAuxDataContext())
 #define BODY_CTX (accessBodyContext())
 #define WITNESS_CTX (accessWitnessContext())
-#endif
 
 handler_fn_t signTx_handleAPDU;
 

src/signTxPoolRegistration.c

@@ -787,7 +787,7 @@ static void signTxPoolRegistration_handleOwnerAPDU(uint8_t* wireDataBuffer, size
 			PRINTF("\n");
 
 			subctx->numOwnersGivenByPath++;
-			ASSERT(!ctx->poolOwnerByPath);
+			VALIDATE(!ctx->poolOwnerByPath, ERR_INVALID_DATA);
 			ctx->poolOwnerByPath = true;
 			memmove(&ctx->poolOwnerPath, &owner->path, SIZEOF(owner->path));
 			break;