Add a notice for scan was incomplete #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichikaway
reviewed
May 27, 2019
src/vaddy/vaddy.go
Outdated
| os.Exit(ERROR_EXIT) | ||
| } else if scan_result.IsIncomplete() { | ||
| fmt.Println("Warning! Scan timed out. \nNo vulnerabilities.") | ||
| postSlackIncompleteWarning(fqdn, scan_id, scan_result.ScanResultUrl) | ||
| os.Exit(ERROR_EXIT) |
There was a problem hiding this comment.
@shin1x1 スキャン時間が足りない場合ではありますが、脆弱性は0件であるため、この場合は SUCCESS_EXIT にしてもらえますか
There was a problem hiding this comment.
@ichikaway 脆弱性がある場合もメッセージが Warning となっており、同じ Warning でも理由によって、exit code が変わるのは混乱するように思いました。
例えば、スキャン未完了時はメッセージを Warning ではなく、Notice にするのはどうでしょうか。
There was a problem hiding this comment.
@shin1x1 確かにWarningとは違いますね。Noticeでお願いします。
src/vaddy/vaddy.go
Outdated
| postSlackVulnerabilitiesWarning(scan_result.AlertCount, fqdn, scan_id, scan_result.ScanResultUrl) | ||
| os.Exit(ERROR_EXIT) | ||
| } else if scan_result.IsIncomplete() { | ||
| fmt.Println("Warning! Scan timed out. \nNo vulnerabilities.") |
There was a problem hiding this comment.
@shin1x1 "Warning! Scan was NOT complete (95%). \nNo vulnerabilities." にしてもらえますか。95%の箇所はレスポンスのJSONにあるCompleteを表示。
src/vaddy/vaddy.go
Outdated
| } | ||
|
|
||
| func postSlackIncompleteWarning(fqdn string, scanID string, scanResultURL string) { | ||
| title := "VAddy Scan was incomplete Warning!!!\n" |
shin1x1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.