Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y: add role="button" to span subIndicator #230

Open
jenlampton opened this issue May 23, 2023 · 1 comment
Open

A11y: add role="button" to span subIndicator #230

jenlampton opened this issue May 23, 2023 · 1 comment

Comments

@jenlampton
Copy link

jenlampton commented May 23, 2023

This is an alternative to #204 since that approach seems quite invasive.

Adding a role attribute could have the same benefit of using a <button> element, and would improve the current state of things significantly without requiring a rewrite.

We do still need to find a way to move the span outside the anchor tag, but I'll leave that for a follow-up.

@laryn
Copy link

laryn commented Jan 23, 2024

I'm noticing that when using the split menu functionality, the +/- button is not keyboard accessible. We could add tabindex="0" to fix that, right? Is that similar to what this ticket is trying to achieve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants