Require Once TypeDefinitions.inc #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he appropriate place to do this but I'm open to a better solution. Kinda feel like I was missing something since practically no SOAP requests will work without this. Also throw an exception if the class map is supposed to be cached but fails. If you're expecting this to be cached but directory permissions prevent it you are going to be wasting a lot of processing time generating it over and over again so it's good to get that feedback instead of debugging why your script is timing out. Maybe a warning would be more appropriate.
|
I'm closing this pull request because the problem autoloading TypeDefinitions.inc was coming from my composer.json settings. I still think it's a good idea to throw an error when the class map can't be cached though, so I may submit a separate pull request for that later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...appropriate place to do this but I'm open to a better solution. Kinda feel like I was missing something since practically no SOAP requests will work without this. Also throw an exception if the class map is supposed to be cached but fails. If you're expecting this to be cached but directory permissions prevent it you are going to be wasting a lot of processing time generating it over and over again so it's good to get that feedback instead of debugging why your script is timing out. Maybe a warning would be more appropriate.