Throw an error if wsdl class map caching is enabled but cache is not writable #2
Conversation
…he appropriate place to do this but I'm open to a better solution. Kinda feel like I was missing something since practically no SOAP requests will work without this. Also throw an exception if the class map is supposed to be cached but fails. If you're expecting this to be cached but directory permissions prevent it you are going to be wasting a lot of processing time generating it over and over again so it's good to get that feedback instead of debugging why your script is timing out. Maybe a warning would be more appropriate.
…mposer.json setup should take care of that.
|
Hi. Sorry for the big delay I was out for a while. Indeed you need a little bit of setup to realise that TypeDefinitions.inc is required. A good composer.json configuration will do it. To understand better you mean the cache is not writable by the user that it's used to run php with, right? |
|
Right. If you're using a server with unix style permissions it's not going to be able to write to that directory by default. There is no documentation about the wsdl class map cache so throwing an error if it can't write the file at least lets the developer know it's happening. I was getting a script execution timeout because it was taking so much time generating the class map over and over again and it took me a bit of debugging to figure out what was going on. Also, you could consider adding the cache file to version control even if it's just blank at first. That way one can set the permissions on the file to be writable instead of the whole directory which doesn't need to be. Can you share your composer.json? I can't just require the package, nothing gets autoloaded, I have to use force it to add all of the namespaces and classes into it's classmap like this: "classmap": [ Other packages like Symphony load fine with just require. |
… the types of some structs like CustomizationFixedIp and CustomizationLinuxOptions. Anything that could be more than one type was being assumed as the default and then errors would ensue when the object had properties not present on the default.
…ss present that extends ManagedObject for that specific type of ManagedObject. It just needs to be of the same type that we are looking for.
…nda ugly right now, could probably make another class for doing this kind of stuff.
…hild entities by name and traversing descendant folders.
…o you can optionally automatically create folders you are looking for if they don't exist.
…ct method beginning with 'Get' from being called. Now it only considers a method to be property retrieval if it begins with 'get'
…r ManagedObject and the functionality is already covered by getReferenceId
…me it needs to connect, Service now will use SessionManager->AcquireCloneTicket and SessionManager->CloneSession to reuse an existing session if possible.
|
I'm just bombarding you with all the commits I've made. Let me know if there is anything you want changed, I can make a new branch, remove whatever changes you don't want and then send a pull request on that. 90e3baa - a pretty important bug fix if you need to use some ambiguous customization types |
…s config->hardware.
…icts with a Service->isMethodAPropertyRetrieval. Essentially, getConfig was already a method of VirtualMachine because it starts with 'get'. For some reason if I add getConfig literally onto VirtualMachine it always returns null.
Throw an error if wsdl class map caching is enabled but cache is not writable
|
I just made a few refactoring by extracting a new exception for detailed messages and introduce the session manager as an extension to handle the clone tickets. I think it's more clear like this. Thanks a lot for all the changes. Really nice work. |
|
Very nice, thanks! |
The result I've had when this happens is a timeout because so much time is taken regenerating the class map over and over again. I think it's worth throwing an error since it's configured to cache and is not able to and it also reduces debugging time.