Add options and bring to 100% code coverage. #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, @sholladay! I like this PR, great stuff! Could you add a few examples to the "Usage" code in the readme? |
sholladay
changed the title
This provides more parameters relevant to image search. In addition to covering those, we now have 100% code coverage from tests, including cases where the user does not provide a search query and when the query returns no results.
|
Updated the PR with full API documentation for everything. How's that @vadimdemedes? Also tested a few more edge cases, bringing coverage up to 100%. Doubled the total line count in the repo. 😎 |
|
Superb work, @sholladay! Thank you and sorry for such a late response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @vadimdemedes, great project!
These changes will enable me to use
google-imagesin an app where image search is a core feature and thus I need users to be able to control the search criteria a bit more.The tests are just copy/paste + the obvious tweaks for the relevant query parameter.