Use md5 hashes instead of md4, which are no longer supported in Node.js v17.x #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
added a commit
to tapjs/treport
that referenced
this pull request
Nov 12, 2021
This required a lot more work than I typically like to do in a single commit. However, there really was no way to get it all working without getting it ALL working, so here we are. React is upgraded to v17, because the only way to silence all ink-derived security advisories was to upgrade ink, which has a dependency on a version of react-reconciler than started requiring react 17 in a minor. This also means that there's entirely new rules about what is allowed to go in what, the <Color> tag is gone, the <Static> tag has a whole different interface, and some other changes. At least Vadim had the decency to do all this in a SemVer major, which is how it should be done. Silencing the ReDOS errors coming from string-length and friends required upgrading to the newer version of string-length, which is of course all-in on ESM now, so that stuff has been moved from being a proper dependency to being a bundled de-ESM-ified version of those deps. I do not like that, but until we stop supporting pre-ESM versions of Node (and rewrite tap in ESM, which... yeah, probably not any time soon?) there's no other way forward that I could see. Making import-jsx work on node 17 required pulling in my git fork for the time being, until vadimdemedes/import-jsx#17 lands in the published version. I think it's probably time to re-think this entire approach, get away from React and JSX in favor of something a bit less cutting-edge.
|
@vadimdemedes Using this in a cli app so adding the necessary |
|
Thanks @isaacs! @sandro-pasquali Thanks for the offer, but this package is pretty much on auto pilot ;) |
vadimdemedes
changed the title
vadimdemedes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.