Add ref and unref to stdin mock
#23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threepointone
added a commit
to partykit/partykit
that referenced
this pull request
Sep 10, 2023
This brings back packaging of dependencies for partykit (and introduces it for create-partykit). We had previously disabled it for deps because of esm/cjs nonsense, but we've now figured out how to make them play decently together. I had to fork ink-testing-library because of vadimdemedes/ink-testing-library#23, I'll remove it once that PR is merged. This also updates ink to 4.4.1, which fixes our previous issue where it was exiting early.
threepointone
added a commit
to partykit/partykit
that referenced
this pull request
Sep 10, 2023
This brings back packaging of dependencies for partykit (and introduces it for create-partykit). We had previously disabled it for deps because of esm/cjs nonsense, but we've now figured out how to make them play decently together. I had to fork ink-testing-library because of vadimdemedes/ink-testing-library#23, I'll remove it once that PR is merged. This also updates ink to 4.4.1, which fixes our previous issue where it was exiting early.
threepointone
added a commit
to partykit/partykit
that referenced
this pull request
Sep 10, 2023
This brings back packaging of dependencies for partykit (and introduces it for create-partykit). We had previously disabled it for deps because of esm/cjs nonsense, but we've now figured out how to make them play decently together. I had to fork ink-testing-library because of vadimdemedes/ink-testing-library#23, I'll remove it once that PR is merged. This also updates ink to 4.4.1, which fixes our previous issue where it was exiting early.
threepointone
added a commit
to partykit/partykit
that referenced
this pull request
Sep 10, 2023
This brings back packaging of dependencies for partykit (and introduces it for create-partykit). We had previously disabled it for deps because of esm/cjs nonsense, but we've now figured out how to make them play decently together. I had to fork ink-testing-library because of vadimdemedes/ink-testing-library#23, I'll remove it once that PR is merged. This also updates ink to 4.4.1, which fixes our previous issue where it was exiting early.
threepointone
added a commit
to partykit/partykit
that referenced
this pull request
Sep 10, 2023
This brings back packaging of dependencies for partykit (and introduces it for create-partykit). We had previously disabled it for deps because of esm/cjs nonsense, but we've now figured out how to make them play decently together. I had to fork ink-testing-library because of vadimdemedes/ink-testing-library#23, I'll remove it once that PR is merged. This also updates ink to 4.4.1, which fixes our previous issue where it was exiting early.
Testing components which use useInput fail, because the mock for Stdin doesn't have `.ref` and `.unref`, which are now used (because of vadimdemedes/ink#616 and vadimdemedes/ink#622) This PR adds these methods to the mocks.
vadimdemedes
changed the title
ref and unref to stdin mock
|
Thank you! |
|
@vadimdemedes thanks for merging this, do you have an estimation when it will be released? |
|
Bump, can this be published? Have to use patches right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing components which use useInput fail, because the mock for Stdin doesn't have
.refand.unref, which are now used (because of vadimdemedes/ink#616 and vadimdemedes/ink#622) This PR adds these methods to the mocks.