Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type definitions from @types/yoga-layout #7

Merged
merged 2 commits into from Mar 16, 2020
Merged

Add type definitions from @types/yoga-layout #7

merged 2 commits into from Mar 16, 2020

Conversation

taras
Copy link
Contributor

@taras taras commented Mar 13, 2020

Motivation

I'm preparing a PR that to Ink that will convert the entire project to TypeScript. I would like to be able to use this package in Ink project without doing anything special in Ink. This also closes #6

Approach

I'm assuming that yoga-layout-prebuilt has the same exports as yoga-layout so I'm importing @types/yoga-layout and exporting them under yoga-layout-prebuilt module.

TODO

  • Add tests for the definitions

@vadimdemedes
Copy link
Owner

No need for tests as this is just re-exporting existing types. Thanks!

@vadimdemedes vadimdemedes merged commit df44ea9 into vadimdemedes:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add index.d.ts file to allow usage with typescript
2 participants