Skip to content

Commit

Permalink
ci: Pin Rust nightly to 2024-02-01 (Lightprotocol#465)
Browse files Browse the repository at this point in the history
The newest Rust nightly removed the `stdsimd` feature in favor of
more grained features (rust-lang/rust#117372).

However, the version of `ahash` we depend on, still requires that
feature. New release of `ahash` (0.8.7) contains a fix, but we can't
upgrade to it without upgrading Anchor.

Pinning Rust nightly seems to be the less intrusive solution for now.
  • Loading branch information
vadorovsky committed Feb 6, 2024
1 parent ad61ce0 commit 39968b0
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,5 +60,5 @@ jobs:
# here... But without that, the toolchain is just not there!
# I will spend more time on debugging this once I can afford burning
# more hours.
rustup toolchain install nightly --component clippy,rustfmt
rustup toolchain install nightly-2024-02-01 --component clippy,rustfmt
./scripts/lint.sh
4 changes: 2 additions & 2 deletions scripts/format.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ set -e
npx nx run-many --target=format --all
npx nx run-many --target=lint:fix --all

cargo +nightly fmt --all
cargo clippy --exclude macro-circom --all -- -A clippy::result_large_err -D warnings
cargo +nightly-2024-02-01 fmt --all
cargo clippy --exclude macro-circom --all -- -A clippy::result_large_err -D warnings
2 changes: 1 addition & 1 deletion scripts/install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ export PATH="${PREFIX}/cargo/bin:${PATH}"

rustup component add clippy
rustup component add rustfmt
rustup toolchain install nightly --component clippy,rustfmt
rustup toolchain install nightly-2024-02-01 --component clippy,rustfmt

cargo install cargo-expand wasm-pack

Expand Down
2 changes: 1 addition & 1 deletion scripts/lint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -e
npx nx run-many --target=format:check --all
npx nx run-many --target=lint --all

for rust_toolchain in stable nightly; do
for rust_toolchain in stable nightly-2024-02-01; do
cargo +"$rust_toolchain" fmt --all -- --check
cargo +"$rust_toolchain" clippy \
--workspace \
Expand Down

0 comments on commit 39968b0

Please sign in to comment.