Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YIN algorithm, conversion of GuitarTuner example to Swift 3 #39

Merged
merged 10 commits into from Oct 23, 2016
Merged

YIN algorithm, conversion of GuitarTuner example to Swift 3 #39

merged 10 commits into from Oct 23, 2016

Commits on Oct 11, 2016

  1. add YIN algorithm 

    http://recherche.ircam.fr/equipes/pcm/cheveign/pss/2002_JASA_YIN.pdf
http://matthiasmauch.de/_pdf/mauch_pyin_2014.pdf
https://code.soundsoftware.ac.uk/projects/pyin/repository
Signed-off-by: Guillaume Laurent <glaurent@telegraph-road.org>
    @glaurent
    glaurent committed Oct 11, 2016
    Copy the full SHA
    f658557 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2016

  1. Finished implementation of YIN algorithm - not tested yet 

    Signed-off-by: Guillaume Laurent <glaurent@telegraph-road.org>
    @glaurent
    glaurent committed Oct 18, 2016
    Copy the full SHA
    40c8000 View commit details
    Browse the repository at this point in the history

  2. Port GuitarTuner example to Swift 3, iOS 10 

    Signed-off-by: Guillaume Laurent <glaurent@telegraph-road.org>
    @glaurent
    glaurent committed Oct 18, 2016
    Copy the full SHA
    9afec12 View commit details
    Browse the repository at this point in the history

  3. Fix crash in YINUtil:difference() function 

    Signed-off-by: Guillaume Laurent <glaurent@telegraph-road.org>
    @glaurent
    glaurent committed Oct 18, 2016
    Copy the full SHA
    8d17738 View commit details
    Browse the repository at this point in the history

  4. Test YIN estimator in GuitarTuner 

    Poor results so far :-(

Signed-off-by: Guillaume Laurent <glaurent@telegraph-road.org>
    @glaurent
    glaurent committed Oct 18, 2016
    Copy the full SHA
    cd81393 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2016

  1. Fixes for the YIN algorithm - much better results 

    Apparently the problem is the YINUtil:difference() function. The simpler (but slower) difference2() gives good results. Setting the threshold to an appropriate value seems to have helped too.

Signed-off-by: Guillaume Laurent <glaurent@telegraph-road.org>
    @glaurent
    glaurent committed Oct 19, 2016
    Copy the full SHA
    8252cd2 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2016

  1. More fixes on the YIN algorith - now giving good results but too CPU … 

    …consuming

Instruments shows that the difference2() function eats more than 50% of CPU. I need to find a faster way to do this, and I can’t seem to get the difference() function working.

Signed-off-by: Guillaume Laurent <glaurent@telegraph-road.org>
    @glaurent
    glaurent committed Oct 22, 2016
    Copy the full SHA
    2b4ca26 View commit details
    Browse the repository at this point in the history

  2. YIN algo : faster, Accelerate-based version of difference() function 

    Drops CPU usage from 95% to 25%.

Signed-off-by: Guillaume Laurent <glaurent@telegraph-road.org>
    @glaurent
    glaurent committed Oct 22, 2016
    Copy the full SHA
    7d1b90b View commit details
    Browse the repository at this point in the history

  3. Re-indent all my files to 2 spaces according to the rest of the project 

    Signed-off-by: Guillaume Laurent <glaurent@telegraph-road.org>
    @glaurent
    glaurent committed Oct 22, 2016
    Copy the full SHA
    152610d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into YINalgorithm

    @glaurent
    glaurent committed Oct 22, 2016
    Copy the full SHA
    d89f9cb View commit details
    Browse the repository at this point in the history