Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cat generator #116

Merged
merged 4 commits into from
May 10, 2019
Merged

Add Cat generator #116

merged 4 commits into from
May 10, 2019

Conversation

51d4
Copy link
Contributor

@51d4 51d4 commented May 8, 2019

Hi @vadymmarkov ,

I added my favourite generator class - Cat

Please take a look :)

Implement CatSpec class
Update en-TEST.json and en.json files
@dunyakirkali
Copy link
Contributor

dunyakirkali commented May 8, 2019

@51d4 Could you also update the README.md with some usage instructions?

Removed copyright header from Cat class
@vadymmarkov
Copy link
Owner

Nice one @51d4! Could you also add this generator to https://github.com/vadymmarkov/Fakery/blob/master/Sources/Fakery/Faker.swift to make it accessible.

@vadymmarkov vadymmarkov merged commit e3ff228 into vadymmarkov:master May 10, 2019
@51d4 51d4 deleted the Feature/Cat branch May 10, 2019 08:49
@51d4 51d4 restored the Feature/Cat branch May 10, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants