Bump to Xcode 11.6 and replace Carthage with SPM in Xcode project #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for better support of Xcode 12 because Carthage does not handle it well (see https://github.com/Carthage/Carthage/blob/master/Documentation/Xcode12Workaround.md).
This is an old "conflict" file.
|
Awesome! Thanks @Liquidsoul! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to build and compile the project using Xcode 12 and failed to do so because of a limitation in Carthage (see Xcode12Workaround).
Instead of adding some information about this workaround or even add the workaround script into the project, I choose to remove Carthage altogether from the project because we can achieve the same result with the build-in SPM in Xcode.
This also have the advantage of removing the lack of documentation about the use of Carthage in the project.
Note that this does not remove support of Carthage when the library is used as a dependency.