Fix error in randomInt with large Ints #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initialisation of the
UInt32
inrandomInt
failed, whenmax - min + 1
was bigger thanUInt32.max
.This can happen because
Int
is aInt64
on 64-bit systems.I replaced
arc4random_uniform
witharc4random_buf
which just fills theInt
with random bits.To transform the random number to a positive one, I used
& Int.max
to set the first bit to0
(which is faster thanabs()
)