Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift version fixes #19

Merged
merged 2 commits into from
Aug 14, 2020
Merged

Swift version fixes #19

merged 2 commits into from
Aug 14, 2020

Conversation

RomanPodymov
Copy link
Contributor

Hello.
Thank you for Fashion.
In this pull request I deleted deprecated .swift-version file and set Swift version with s.swift_versions.
Probably fixed #18.

@vadymmarkov vadymmarkov merged commit b7e513d into vadymmarkov:master Aug 14, 2020
@vadymmarkov
Copy link
Owner

Thanks @RomanPodymov

@larsriehn
Copy link

@vadymmarkov Thank you for looking at my request. Unfortunately it does not fix my problem.
Roman did change something but not in the file I mentioned and I think this still is the problem.
When I look in Fashion.debug.podspecc (or Fashion.release.podspecc) I see this line:
SWIFT_VERSION = 3.0
When I look in *.podspec files of other pod's they do not have this line at all.

@RomanPodymov
Copy link
Contributor Author

Hello @larsriehn
In #18 you mentioned https://github.com/CocoaPods/Specs/blob/master/Specs/9/3/e/Fashion/4.0.0/Fashion.podspec.json. But now the latest Fashion version is 4.2.0 and in https://github.com/CocoaPods/Specs/blob/master/Specs/9/3/e/Fashion/4.2.0/Fashion.podspec.json "swift_version" is "5.0". Could you please provide us a small project where we can reproduce your issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swift version still 3 in podspec at CocoaPods
3 participants