Add extra accels for 'Add cell' and 'Delete cell' menu items #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadz
reviewed
Jun 5, 2022
| @@ -382,11 +382,19 @@ | |||
| </object> | |||
| <object class="wxMenuItem" name="add_cell"> | |||
| <label>_Add cell\tCtrl-+</label> | |||
| <extra-accels> | |||
| <accel>Shift-Ctrl-+</accel> | |||
| <accel>Ctrl-Num-+</accel> | |||
There was a problem hiding this comment.
I've finally tested this (better late than never...) and this just doesn't seem to work, we need to use Ctrl-Num + for this accelerator to be triggered by the "+" key on the numpad. Am I missing something here and this was somehow broken by 3396a40015 (Mark keyboard key names translatable in a specific context, 2022-04-24) in wx in the meanwhile or did it really never work at all?
vadz
pushed a commit
that referenced
this pull request
Jun 9, 2022
/opt/lmi/src/lmi/fdlibm_expm1.c:243:13: runtime error: left shift of negative value -2
#0 0x5633bb2b0576 in fdlibm_expm1 /opt/lmi/src/lmi/fdlibm_expm1.c:243
#1 0x5633bb2f18ba in test_expm1_log1p() /opt/lmi/src/lmi/math_functions_test.cpp:662
let-me-illustrate#2 0x5633bb2fb7ea in test_main(int, char**) /opt/lmi/src/lmi/math_functions_test.cpp:804
let-me-illustrate#3 0x5633bb2fbd56 in cpp_main(int, char**) /opt/lmi/src/lmi/test_main.cpp:171
[uninteresting let-me-illustrate#4 - let-me-illustrate#8 snipped]
vadz
pushed a commit
that referenced
this pull request
Jun 11, 2022
'daily_interest_accounting' had been used before initialization. Defect identified by ASan [reformatted]: #0 in AccountValue::CoordinateCounters() ihs_acctval.cpp:1486 #1 in AccountValue::SetInitialValues() ihs_acctval.cpp:614 let-me-illustrate#2 in AccountValue::AccountValue(Input const&) ihs_acctval.cpp:109 Fixed by moving the initialization. Resisted the temptation simply to initialize it in the header, which would have left the defect intact but restored its invisibility. Although this defect was introduced 20050114T1947Z into CVS, it comes from an original file predating the lmi epoch.
vadz
pushed a commit
that referenced
this pull request
Jun 27, 2022
Build this unit test using x86_64-pc-linux-gnu, with "build_type=ubsan",
and with these variables:
UBSAN_OPTIONS
ASAN_OPTIONS
defined and exported as in 'gwc/.zshrc', to see:
/opt/lmi/src/lmi/fdlibm_expm1.c:242:13: runtime error: left shift of negative value -2
#0 0x5584d6736063 in fdlibm_expm1 /opt/lmi/src/lmi/fdlibm_expm1.c:242
#1 0x5584d67a05e6 in test_expm1_log1p() /opt/lmi/src/lmi/math_functions_test.cpp:660
let-me-illustrate#2 0x5584d67b2b6b in test_main(int, char**) /opt/lmi/src/lmi/math_functions_test.cpp:848
let-me-illustrate#3 0x5584d67b3396 in cpp_main(int, char**) /opt/lmi/src/lmi/test_main.cpp:171
Before this change, the UB was detected, but the call stack didn't
identify which of millions of loop iterations triggered it. Now the
triggering example is isolated and discussed in some detail.
By default, this unit test wouldn't be built with UBSan because it's
named in $(excluded_unit_test_targets), but it is possible to run it
manually as above.
|
(A modified version of) this PR is now part of let-me-illustrate#220 and will be merged when that PR is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.