Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra accels for 'Add cell' and 'Delete cell' menu items #1

Closed
wants to merge 1 commit into from
Closed

Add extra accels for 'Add cell' and 'Delete cell' menu items #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions menus.xrc
View file
Open in desktop
Expand Up @@ -382,11 +382,19 @@
</object>
<object class="wxMenuItem" name="add_cell">
<label>_Add cell\tCtrl-+</label>
<extra-accels>
<accel>Shift-Ctrl-+</accel>
<accel>Ctrl-Num-+</accel>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've finally tested this (better late than never...) and this just doesn't seem to work, we need to use Ctrl-Num + for this accelerator to be triggered by the "+" key on the numpad. Am I missing something here and this was somehow broken by 3396a40015 (Mark keyboard key names translatable in a specific context, 2022-04-24) in wx in the meanwhile or did it really never work at all?

</extra-accels>
<bitmap platform="win" stock_id="insert-rows"/>
<help>Add a new cell with case default parameters</help>
</object>
<object class="wxMenuItem" name="delete_cells">
<label>_Delete cell(s)\tCtrl--</label>
<extra-accels>
<accel>Shift-Ctrl--</accel>
<accel>Ctrl-Num--</accel>
</extra-accels>
<bitmap platform="win" stock_id="delete-row"/>
<help>Delete selected cell(s)</help>
</object>
Expand Down